hi Frans,

I'm happy to review these patches (and think I have for some already), but as my Braswell-based ChromeOS boards don't require them, a little more explanation in the commit msgs as to what issue they are resolving would be helpful in that regard.  Obviously I'd like to test them and ensure no regressions for my boards as well

I have added some comments to these patches. As ChromeOS may not require them (and I am aware of that since I worked once with Chromebook), the SeaBIOS payload have problems (especially with interrupts and keyboard input) and other operating systems complain. We are awaiting for Your review.

I have added short comments on few of these patches. Feel free to ask questions under the patches, I will hopefully give satisfying answers.

cheers,
Matt

On Thu, Feb 28, 2019 at 2:42 AM Frans Hendriks <fhendriks@eltan.com> wrote:

An additional question related to this SoC and new mainboards:
Should maintainer of Braswell SoC also take care of review/merge new mainboards based on this chipset?

Who should merge new boards?
(I have uploaded code for two mainboards based on this SoC, where 1 is waiting 3 months to be merged?)

Best regards,
Frans Hendriks
Eltan B.V.

-----Original Message-----
From: Patrick Rudolph [mailto:patrick.rudolph@9elements.com]
Sent: donderdag 28 februari 2019 09:20
To: Michal Zygowski <michal.zygowski@3mdeb.com>; coreboot@coreboot.org
Subject: [coreboot] Re: Intel Braswell uploads

On Thu, 2019-02-28 at 08:51 +0100, Michal Zygowski wrote:
> I would like to submit my candidacy for Braswell SoC maintainership
> along with Piotr Król. Since we have 3 Braswell SoC platforms on hand,
> we are willing to test any incoming patches to Braswell SoC code base.
> We would be glad to become the maintainers. Would like to hear Your
> opinions, dear coreboot developers/maintainers, what do You think
> about the change?

Hi Michal,
I'm glad to see that you want to maintain an additional platform.

I recommend to email all maintainers, that are not known to be active, as part of the half year release process. If you don't get a response or a bounce message the platform should be marked as unmaintained.

What do you think about adding a "supporters section" to the start page of https://coreboot.org/ to ackknowledge companies that really maintain coreboot code.

Regards,
--
Patrick Rudolph

9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email:  patrick.rudolph@9elements.com
Phone:  +49 234 68 94 188

Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Daniel Hoelzgen _______________________________________________
coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-leave@coreboot.org
_______________________________________________
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-leave@coreboot.org

_______________________________________________
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-leave@coreboot.org

-- 
Michał Żygowski
Firmware Engineer
http://3mdeb.com | @3mdeb_com