Le 29 mai 2018 à 16:48, Sumo <kingsumos@gmail.com> a écrit :

Hi,

Today denverton_core_init() is enabling the Intel SpeedStep only if turbo mode is available. As a result, the SpeedStep is not enable for the C3558 variant (and others).  Any clues of why it was implemented this way?
I think it is safe to remove the "if (get_turbo_state() == TURBO_ENABLED)" test and always enable the SpeedStep technology.

You are right, I also think it’s safe. (The variant I have access to have Turbo so I can’t test it).
I also have no clue, but it was like this since the first denverton commit… 
So please test and submit a patch ;)

Best Regads
Julien


Thanks,
Sumo





--
coreboot mailing list: coreboot@coreboot.org
https://mail.coreboot.org/mailman/listinfo/coreboot

--
Julien Viard de Galbert - jviarddegalbert@online.net
Online / Scaleway
Looking for an amazing job? Join us NOW ! https://careers.scaleway.com/