Myles Watson wrote:
How should we really fix it? In v3 didn't we just scrap type 2 accesses all together?
We can keep the type 2 support code, but the auto detection at run time makes absolutely no sense.
I sent a patch for this some days ago, but I think Carl-Daniel didn't have too much success with it on his board.
Maybe we could simplify it a little and try again. It looks like the
rs690
changes were pretty extensive.
Generally, we should also change the mainboard code to access pci devices in ->init, not in ->enable. This should solve the issues.
I thought enable was run at the very beginning, before scan, while init was run at the end. That seems like a hard conversion to make.
Thanks, Myles