On 3/25/10 11:46 PM, Stefan Reinauer wrote: 
On 3/25/10 11:07 PM, Myles Watson wrote:
  
@@ -273,8 +273,10 @@
     acpi_create_facs(facs);

     dsdt = (acpi_header_t *) current;
-    current += AmlCode.length;
-    memcpy((void *) dsdt, &AmlCode, AmlCode.length);
+    memcpy((void *) dsdt, AmlCode, sizeof(acpi_header_t));
+    int len = dsdt->length;
+    current += len;
+    memcpy((void *) dsdt, AmlCode, len);
    
      
Why not:
  
    
+    current += dstd->length;
+    memcpy((void *) dsdt, AmlCode, dsdt->length);
    
      
I don't think the extra variable adds anything.

I'll ack that.
  
    
This is not all boards yet, but I send them out so I can go to bed :-)

ping