Ulf Jordan wrote:
> On Fri, 11 Apr 2008, svn@coreboot.org wrote:
>
>> +int isxdigit(int c)
>> +{
>> + return isdigit(c) || (tolower(c)>= 'a' && tolower(c) <= 'z');
>> +}
>
> Shouldn't this be
>
> return isdigit(c) || (tolower(c)>= 'a' && tolower(c) <= 'f');
jep it should..
but why not :
return isdigit(c) || c>= 'a' && c <= 'f' || c>= 'A' && c <= 'F' );
it might be even faster if you do
return isdigit(c) || (c & ~0x20)>= 'A' && (c & ~0x20) <= 'F' );
>
>
> /ulf
>

---

Express yourself instantly with MSN Messenger! MSN Messenger