Hi,
Iru Cai wrote:
I've been testing the Lenovo T420 port recently, and now I can install an Ivy Bridge processor and run fine on Linux(except some thermal issues).
That's pretty nice I think.
However, the native graphics initialization doesn't work properly
..
I don't know if someone has tried using mixed generation of CPU and chipset combination with coreboot before,
Probably not.
I have pushed the patch that makes coreboot support both SNB and IVB processor for review: http://review.coreboot.org/#/c/12087/
Thanks! There is a source code style issue - you used two spaces instead of one tab to indent - please fix that, but other than that the patch looks fine to me.
But the two files gma_{sandy,ivy}bridge_lvds.c are a bit of a mess - they need to be cleaned up and can quite easily be unified into a single file, without having it become the mess that the i915 kernel code is. The key is to have a good data model, and the data model seems clear to me from the existing code.
For fun (or pain), take a look at: git diff 758a41 7137c5 (sandy..ivy)
//Peter