On Tue, Oct 5, 2010 at 1:15 PM, ron minnich email@example.com wrote:
I think I'm happier if other newer commiters ack this stuff. I don't work with the code frequently enough to feel comfortable acking some of these things.
Fair enough. Anyone else have any comments?
I'm very happy with macros that make data definitions clearer. I'm very worried about assembly code macros because this is tricky assembly and people fall into certain habits in terms of thinking macros are side-effect-free, which they are not in this case.
Let me throw together a patch and see what you and others think.