ok, but looking at
https://review.coreboot.org/#/c/coreboot/+/26512/, is there any single thing in there that stands out as a a problem? Every single change looks better to me.
I still don't see the problem with 132. I did a quick check on the Go source tree, where there basically are no limits for 10 years now, and there are very few cases where lines are longer than 80, but in those cases, readability is superior for those long lines. I suspect, based on my little test, that the same is true of coreboot. People tend to write to 80, but occasionally, things are longer, and at least for me, this
printk(BIOS_DEBUG, "Exception: %s\n", exception_names[tf->cause]);
is much more readable than this
printk(BIOS_DEBUG, "Exception: %s\n",
exception_names[tf->cause]);
I'm fine with strongly recommending we stick to 80, but I'd really like to get away from making it mandatory. And, further, I'd like to see us move to clang-format on commits, so we can end these discussions as they have ended them in the Go and Rust communities.
If somebody every submits a 512-length line, I think we can convince them to see reason :-)
ron