Re: [coreboot] patch: set dbe62 to have com2 on com1 address

[Carl-Daniel Hailfinger]

On 05.03.2008 06:51, ron minnich wrote:
> I still have no LPC dongle, but I am getting closer. I really liked
> this as it shows off the power of our new
> config system, the dts. There is a whole function in v2 to make com2
> operate at the com1 address. For v3, we just set
> a value in the mainboard dts and we're done (in theory ; I can't tell
> if this works). DBE62 is getting through a lot of POST
> btw but hangs at 13.
>
> I just realized this exampel also shows that you do NOT want all dts
> values to be visible in Kconfig.
> It would make no sense to change these
> values on the dbe62.
>
> Signed-off-by: Ronald G. Minnich

Acked-by: Carl-Daniel Hailfinger
> Index: mainboard/artecgroup/dbe62/dts
>
> --- mainboard/artecgroup/dbe62/dts      (revision 630)
> +++ mainboard/artecgroup/dbe62/dts      (working copy)
> @@ -43,6 +43,10 @@
>                         /* GPIO(0-0x20) for INT D:C:B:A, 0xFF=none.
>                          * See virtual PIC spec. */
>                         enable_gpio_int_route = "0x0D0C0700";
>                   /* we use com2 since that is on the dongle */

Uppercase the W in "we"?
>                   com2_enable = "1";
>                   /* Set com2 address to be COM1 */
>                   com2_address = "0x3f8";
>           };
>   };
>
> };

If you look at the dbe61 dts, you can see the same settings except that 
dbe61 additionally sets com2_irq = "4".

Regards,
Carl-Daniel