On Fri, Sep 25, 2009 at 11:57 AM, Stefan Reinauer <stepan@coresystems.de> wrote:
Myles Watson wrote:
>> What about we stop the spew rather than changing the algorithm?
>>
> I think both need to be done.  On a mainboard with many devices it
> seems silly to keep looking through the same two CBFS entries for
> ROMs.  Is there a reason to do it that way that I'm missing?
>
Well, it's quite against the device centric model we have at the
moment... That made me hesitate.
That's a valid point.  Now I wonder how it could be implemented so that we get the precedence of CBFS then ROM if it exists correct, so that only one gets executed.
 
But your reasons are very sound. It's quite a lot of cbfs accesses, and
generally I guess walking the device tree (in coreboot it's even a
memory op, and not a pci config space op) is cheaper than walking all of
the rom all of the time..
It's not a show-stopper for me, but I thought I'd bring it up when I came to it.

Thanks,
Myles