coreboot

coreboot@coreboot.org

6 participants
39687 discussions

[coreboot - Bug #315] (New) Xorg/Wayland show black screen when system memory is 4GB or higher
by coreboot＠fe80.eu 02 Aug '21

02 Aug '21

Issue #315 has been reported by Master Geek. ---------------------------------------- Bug #315: Xorg/Wayland show black screen when system memory is 4GB or higher https://ticket.coreboot.org/issues/315 * Author: Master Geek * Status: New * Priority: Normal * Assignee: * Category: * Target version: ---------------------------------------- Board: ASROCK G41M-VS3 R2.0 CB Revision: coreboot-4.14-1258-gfbc46a3bfb When this board has one memory stick with 2GB of ram, or two memory sticks with 1GB and 2GB (3GB total) there's no issue with display; Xorg and wayland (using weston) work as expected. But when there's 4GB or maybe more (two 2GB sticks only available, haven't tried a single 4GB stick) the system works as expected up to just before starting Xorg or wayland, the screen goes black and nothing else happens. Returning to a tty by means of Ctrl-Alt-# 'ing to some other tty doesn't bring display back, neither does exitting/killing Xorg or wayland. Not even forcefully removing and reloading the relevant kernel modules (i915, drm) does anything to bring the display back, display will only comeback with a reboot. When the screen goes black there's no system freeze of any kind, and the kernel complains with a single line: "i915 0000:00:02.0: [drm] *ERROR* CPU pipe A FIFO underrun" that isn't very helpful for debugging imo. Attached dmesg loglevel=9 logs of stock bios, coreboot with 4GB (coreboot_bad) and with 2GB (coreboot_good), cbmem console log of coreboot with 2GB (cbmem_good). ---Files-------------------------------- cb_config.txt (16.3 KB) cbmem_good.log (31.3 KB) dmesg_coreboot_bad.log (443 KB) dmesg_coreboot_good.log (457 KB) dmesg_stock_bios.log (315 KB) -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 0

[coreboot - Bug #314] (New) Please disable 'administrator approval' on ticket.coreboot.org
by coreboot＠fe80.eu 30 Jul '21

30 Jul '21

Issue #314 has been reported by akjuxr3 akjuxr3. ---------------------------------------- Bug #314: Please disable 'administrator approval' on ticket.coreboot.org https://ticket.coreboot.org/issues/314 * Author: akjuxr3 akjuxr3 * Status: New * Priority: Normal * Assignee: * Category: infrastructure * Target version: ---------------------------------------- Please disable this 'administrator approval' on ticket.coreboot.org. It feels like discrimination. Before i have written the first word on ticket.coreboot.org i have to be approved by someone by hand without this person knowing anything from me. I had to wait several days for this approval. Its completely unclear what is been tracked. Have the IP-address used for registration been tracked? Have the used email-address been tracked? E-mail-address-discrimination is illegal in many countries and this is completely breaking the freedom of choice! Username? Choosing (user)names is up to the user and making decision based on what names are 'allowed' to enter a platform is the most racist thing possible. Conclusion: This 'administrator approval' is sort of discrimination i have not seen for years on free projects! There is no data available at the registration process that could or should be used to decide who is allowed to report a bug in the coreboot project. Please disable this discrimination that is stopping people for days or even forever to report a coreboot issue. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 0

New Defects reported by Coverity Scan for coreboot
by scan-admin＠coverity.com 30 Jul '21

30 Jul '21

Hi, Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan. 20 new defect(s) introduced to coreboot found with Coverity Scan. 13 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 20 of 20 defect(s) ** CID 1461240: Control flow issues (DEADCODE) /3rdparty/chromeec/core/cortex-m/watchdog.c: 37 in watchdog_trace() ________________________________________________________________________________________________________ *** CID 1461240: Control flow issues (DEADCODE) /3rdparty/chromeec/core/cortex-m/watchdog.c: 37 in watchdog_trace() 31 32 /* 33 * This is our last breath, the last opportunity to sort out all 34 * matters. Flush and invalidate D-cache if cache enabled. 35 */ 36 if (IS_ENABLED(CONFIG_ARMV7M_CACHE)) >>> CID 1461240: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "cpu_clean_invalidate_dcache();". 37 cpu_clean_invalidate_dcache(); 38 39 panic_printf("### WATCHDOG PC=%08x / LR=%08x / pSP=%08x ", 40 stack[6], stack[5], psp); 41 if ((excep_lr & 0xf) == 1) 42 panic_puts("(exc) ###\n"); ** CID 1461239: (PARSE_ERROR) /3rdparty/chromeec/common/shared_mem.c: 19 in () /3rdparty/chromeec/common/shared_mem.c: 19 in () /3rdparty/chromeec/common/shared_mem.c: 19 in () ________________________________________________________________________________________________________ *** CID 1461239: (PARSE_ERROR) /3rdparty/chromeec/common/shared_mem.c: 19 in () 13 #include "util.h" 14 15 static int buf_in_use; 16 static int max_used; 17 18 /* 1 MB buffer for fake shared memory implementation */ >>> CID 1461239: (PARSE_ERROR) >>> expression must be an integral constant expression 19 STATIC_IF(CONFIG_FAKE_SHMEM) char fake_shmem_buf[BIT(20)]; 20 21 int shared_mem_size(void) 22 { 23 if (IS_ENABLED(CONFIG_FAKE_SHMEM)) 24 return sizeof(fake_shmem_buf); /3rdparty/chromeec/common/shared_mem.c: 19 in () 13 #include "util.h" 14 15 static int buf_in_use; 16 static int max_used; 17 18 /* 1 MB buffer for fake shared memory implementation */ >>> CID 1461239: (PARSE_ERROR) >>> function call is not allowed in a constant expression 19 STATIC_IF(CONFIG_FAKE_SHMEM) char fake_shmem_buf[BIT(20)]; 20 21 int shared_mem_size(void) 22 { 23 if (IS_ENABLED(CONFIG_FAKE_SHMEM)) 24 return sizeof(fake_shmem_buf); /3rdparty/chromeec/common/shared_mem.c: 19 in () 13 #include "util.h" 14 15 static int buf_in_use; 16 static int max_used; 17 18 /* 1 MB buffer for fake shared memory implementation */ >>> CID 1461239: (PARSE_ERROR) >>> expression must have integral type 19 STATIC_IF(CONFIG_FAKE_SHMEM) char fake_shmem_buf[BIT(20)]; 20 21 int shared_mem_size(void) 22 { 23 if (IS_ENABLED(CONFIG_FAKE_SHMEM)) 24 return sizeof(fake_shmem_buf); ** CID 1461238: Control flow issues (DEADCODE) /3rdparty/chromeec/common/usb_pd_alt_mode_dfp.c: 1312 in svdm_dp_post_config() ________________________________________________________________________________________________________ *** CID 1461238: Control flow issues (DEADCODE) /3rdparty/chromeec/common/usb_pd_alt_mode_dfp.c: 1312 in svdm_dp_post_config() 1306 1307 __overridable void svdm_dp_post_config(int port) 1308 { 1309 mux_state_t mux_mode = svdm_dp_get_mux_mode(port); 1310 /* Connect the SBU and USB lines to the connector. */ 1311 if (IS_ENABLED(CONFIG_USBC_PPC_SBU)) >>> CID 1461238: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "ppc_set_sbu(port, 1);". 1312 ppc_set_sbu(port, 1); 1313 usb_mux_set(port, mux_mode, USB_SWITCH_CONNECT, 1314 polarity_rm_dts(pd_get_polarity(port))); 1315 1316 dp_flags[port] |= DP_FLAGS_DP_ON; 1317 if (!(dp_flags[port] & DP_FLAGS_HPD_HI_PENDING)) ** CID 1461237: Control flow issues (DEADCODE) /3rdparty/chromeec/common/motion_sense.c: 446 in motion_sense_switch_sensor_rate() ________________________________________________________________________________________________________ *** CID 1461237: Control flow issues (DEADCODE) /3rdparty/chromeec/common/motion_sense.c: 446 in motion_sense_switch_sensor_rate() 440 /* No sensor activated, reset host interval interval to 0. */ 441 ap_event_interval = 0; 442 } 443 444 /* disable the body detection since AP is suspended */ 445 if (IS_ENABLED(CONFIG_BODY_DETECTION)) { >>> CID 1461237: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "static _Bool was_enabled;". 446 static bool was_enabled; 447 448 switch (sensor_active) { 449 case SENSOR_ACTIVE_S3: 450 was_enabled = body_detect_get_enable(); 451 body_detect_set_enable(false); ** CID 1461236: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /3rdparty/chromeec/common/chargen.c: 95 in command_chargen() ________________________________________________________________________________________________________ *** CID 1461236: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /3rdparty/chromeec/common/chargen.c: 95 in command_chargen() 89 continue; 90 91 watchdog_reload(); 92 prev_watchdog_time.val = current_time.val; 93 } 94 >>> CID 1461236: Integer handling issues (CONSTANT_EXPRESSION_RESULT) >>> "({...; 0;}) && c == 48" is always false regardless of the values of its operands. This occurs as the logical operand of "if". 95 if (IS_ENABLED(CONFIG_ZEPHYR) && c == '0') 96 watchdog_reload(); 97 98 putc_(c++); 99 100 if (seq_number && (++seq_counter == seq_number)) ** CID 1461235: Control flow issues (DEADCODE) /3rdparty/chromeec/common/panic_output.c: 182 in get_panic_data_start() ________________________________________________________________________________________________________ *** CID 1461235: Control flow issues (DEADCODE) /3rdparty/chromeec/common/panic_output.c: 182 in get_panic_data_start() 176 uintptr_t get_panic_data_start(void) 177 { 178 if (pdata_ptr->magic != PANIC_DATA_MAGIC) 179 return 0; 180 181 if (IS_ENABLED(CONFIG_ZEPHYR)) >>> CID 1461235: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return (uintptr_t)pdata_ptr;". 182 return (uintptr_t)pdata_ptr; 183 184 return ((uintptr_t)CONFIG_PANIC_DATA_BASE 185 + CONFIG_PANIC_DATA_SIZE 186 - pdata_ptr->struct_size); 187 } ** CID 1461234: Control flow issues (DEADCODE) /3rdparty/chromeec/common/system.c: 850 in system_get_board_version() ________________________________________________________________________________________________________ *** CID 1461234: Control flow issues (DEADCODE) /3rdparty/chromeec/common/system.c: 850 in system_get_board_version() 844 */ 845 int system_get_board_version(void) 846 { 847 int board_id; 848 849 if (IS_ENABLED(CONFIG_BOARD_VERSION_CBI)) { >>> CID 1461234: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "int error;". 850 int error; 851 852 error = cbi_get_board_version(&board_id); 853 if (error) 854 return -error; 855 ** CID 1461233: Control flow issues (DEADCODE) /3rdparty/chromeec/common/charge_manager.c: 418 in charge_manager_fill_power_info() ________________________________________________________________________________________________________ *** CID 1461233: Control flow issues (DEADCODE) /3rdparty/chromeec/common/charge_manager.c: 418 in charge_manager_fill_power_info() 412 r->type = USB_CHG_TYPE_NONE; 413 r->meas.voltage_max = 0; 414 r->meas.voltage_now = 415 r->role == USB_PD_PORT_POWER_SOURCE ? 5000 : 0; 416 /* TCPMv2 tracks source-out current in the DPM */ 417 if (IS_ENABLED(CONFIG_USB_PD_TCPMV2)) >>> CID 1461233: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "r->meas.current_max = dpm_g...". 418 r->meas.current_max = 419 dpm_get_source_current(port); 420 else 421 r->meas.current_max = 422 charge_manager_get_source_current(port); 423 r->max_power = 0; ** CID 1461232: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /3rdparty/chromeec/common/usb_pd_alt_mode_dfp.c: 896 in is_tbt_cable_superspeed() ________________________________________________________________________________________________________ *** CID 1461232: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /3rdparty/chromeec/common/usb_pd_alt_mode_dfp.c: 896 in is_tbt_cable_superspeed() 890 if (disc->identity.idh.product_type == IDH_PTYPE_ACABLE) 891 return true; 892 893 if (disc->identity.idh.product_type != IDH_PTYPE_PCABLE) 894 return false; 895 >>> CID 1461232: Integer handling issues (CONSTANT_EXPRESSION_RESULT) >>> "({...; 0;}) && is_pd_rev3(port, TCPC_TX_SOP_PRIME)" is always false regardless of the values of its operands. This occurs as the logical operand of "if". 896 if (IS_ENABLED(CONFIG_USB_PD_REV30) && 897 is_pd_rev3(port, TCPC_TX_SOP_PRIME)) 898 return disc->identity.product_t1.p_rev30.ss == 899 USB_R30_SS_U32_U40_GEN1 || 900 disc->identity.product_t1.p_rev30.ss == 901 USB_R30_SS_U32_U40_GEN2 || ** CID 1461231: Control flow issues (DEADCODE) /3rdparty/chromeec/common/usb_common.c: 542 in usb_mux_set_safe_mode_exit() ________________________________________________________________________________________________________ *** CID 1461231: Control flow issues (DEADCODE) /3rdparty/chromeec/common/usb_common.c: 542 in usb_mux_set_safe_mode_exit() 536 if (IS_ENABLED(CONFIG_USBC_SS_MUX)) 537 usb_mux_set(port, USB_PD_MUX_NONE, USB_SWITCH_CONNECT, 538 polarity_rm_dts(pd_get_polarity(port))); 539 540 /* Isolate the SBU lines. */ 541 if (IS_ENABLED(CONFIG_USBC_PPC_SBU)) >>> CID 1461231: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "ppc_set_sbu(port, 0);". 542 ppc_set_sbu(port, 0); 543 } 544 545 static void pd_send_hard_reset(int port) 546 { 547 task_set_event(PD_PORT_TO_TASK_ID(port), PD_EVENT_SEND_HARD_RESET); ** CID 1461230: Control flow issues (DEADCODE) /3rdparty/chromeec/common/usb_pd_alt_mode_dfp.c: 197 in pd_dfp_dp_get_pin_mode() ________________________________________________________________________________________________________ *** CID 1461230: Control flow issues (DEADCODE) /3rdparty/chromeec/common/usb_pd_alt_mode_dfp.c: 197 in pd_dfp_dp_get_pin_mode() 191 /* 192 * Default dp_port_mf_allow is true, we allow mf operation 193 * if UFP_D supports it. 194 */ 195 196 if (IS_ENABLED(CONFIG_CMD_MFALLOW)) >>> CID 1461230: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "mf_pref" inside this statement: "mf_pref = (dp_status[port] ...". 197 mf_pref = PD_VDO_DPSTS_MF_PREF(dp_status[port]) && 198 dp_port_mf_allow[port]; 199 else 200 mf_pref = PD_VDO_DPSTS_MF_PREF(dp_status[port]); 201 202 if (!modep) ** CID 1461229: Control flow issues (DEADCODE) /3rdparty/chromeec/common/uart_buffering.c: 112 in uart_tx_char_raw() ________________________________________________________________________________________________________ *** CID 1461229: Control flow issues (DEADCODE) /3rdparty/chromeec/common/uart_buffering.c: 112 in uart_tx_char_raw() 106 tx_next_snapshot_head = tx_buf_new_tail; 107 108 tx_buf[tx_buf_head] = c; 109 tx_buf_head = tx_buf_next; 110 111 if (IS_ENABLED(CONFIG_PRESERVE_LOGS)) >>> CID 1461229: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "tx_checksum = uart_buffer_c...". 112 tx_checksum = uart_buffer_calc_checksum(); 113 #endif 114 return 0; 115 } 116 117 #ifdef CONFIG_UART_TX_DMA ** CID 1461228: Control flow issues (DEADCODE) /3rdparty/chromeec/common/system.c: 126 in system_get_sku_id() ________________________________________________________________________________________________________ *** CID 1461228: Control flow issues (DEADCODE) /3rdparty/chromeec/common/system.c: 126 in system_get_sku_id() 120 return 0; 121 } 122 123 uint32_t system_get_sku_id(void) 124 { 125 if (IS_ENABLED(CONFIG_HOSTCMD_AP_SET_SKUID)) >>> CID 1461228: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return ap_sku_id;". 126 return ap_sku_id; 127 128 return board_get_sku_id(); 129 } 130 131 /** ** CID 1461227: Control flow issues (DEADCODE) /3rdparty/chromeec/common/charger.c: 460 in charger_discharge_on_ac() ________________________________________________________________________________________________________ *** CID 1461227: Control flow issues (DEADCODE) /3rdparty/chromeec/common/charger.c: 460 in charger_discharge_on_ac() 454 enum ec_error_list charger_discharge_on_ac(int enable) 455 { 456 int chgnum; 457 int rv = EC_ERROR_UNIMPLEMENTED; 458 459 if (IS_ENABLED(CONFIG_CHARGER_DISCHARGE_ON_AC_CUSTOM)) >>> CID 1461227: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return board_discharge_on_a...". 460 return board_discharge_on_ac(enable); 461 462 /* 463 * When discharge on AC is selected, cycle through all chargers to 464 * enable or disable this feature. 465 */ ** CID 1461226: Control flow issues (DEADCODE) /3rdparty/chromeec/core/cortex-m/panic.c: 427 in ignore_bus_fault() ________________________________________________________________________________________________________ *** CID 1461226: Control flow issues (DEADCODE) /3rdparty/chromeec/core/cortex-m/panic.c: 427 in ignore_bus_fault() 421 exception_panic(); 422 } 423 424 void ignore_bus_fault(int ignored) 425 { 426 if (IS_ENABLED(CHIP_FAMILY_STM32H7)) { >>> CID 1461226: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "if (ignored == 0) asm("ds...". 427 if (ignored == 0) 428 asm volatile("dsb; isb"); 429 } 430 431 /* 432 * Flash code might call this before cpu_init(), ** CID 1461225: Control flow issues (DEADCODE) /3rdparty/chromeec/common/system.c: 333 in get_jump_data() ________________________________________________________________________________________________________ *** CID 1461225: Control flow issues (DEADCODE) /3rdparty/chromeec/common/system.c: 333 in get_jump_data() 327 */ 328 if (IS_ENABLED(CONFIG_ZEPHYR)) { 329 /* 330 * For Zephyr, the panic data is not at the end of RAM so 331 * the jump data is always at the end of RAM. 332 */ >>> CID 1461225: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "addr = 536903680U;". 333 addr = CONFIG_RAM_BASE + CONFIG_RAM_SIZE; 334 } else { 335 addr = get_panic_data_start(); 336 if (!addr) 337 addr = CONFIG_RAM_BASE + CONFIG_RAM_SIZE; 338 } ** CID 1461224: Control flow issues (DEADCODE) /3rdparty/chromeec/common/keyboard_scan.c: 616 in board_keyboard_row_refresh() ________________________________________________________________________________________________________ *** CID 1461224: Control flow issues (DEADCODE) /3rdparty/chromeec/common/keyboard_scan.c: 616 in board_keyboard_row_refresh() 610 } 611 612 static uint8_t keyboard_mask_refresh; 613 __overridable uint8_t board_keyboard_row_refresh(void) 614 { 615 if (IS_ENABLED(CONFIG_KEYBOARD_REFRESH_ROW3)) >>> CID 1461224: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return 3;". 616 return 3; 617 else 618 return 2; 619 } 620 621 #ifdef CONFIG_KEYBOARD_BOOT_KEYS ** CID 1461223: (DEADCODE) /3rdparty/chromeec/util/genvif.c: 3379 in init_vif_component_pd_source_fields() /3rdparty/chromeec/util/genvif.c: 3384 in init_vif_component_pd_source_fields() ________________________________________________________________________________________________________ *** CID 1461223: (DEADCODE) /3rdparty/chromeec/util/genvif.c: 3379 in init_vif_component_pd_source_fields() 3373 switch (resp) { 3374 case 0: 3375 set_vif_field(&vif_fields[PD_OCP_Method], 3376 vif_component_name[PD_OCP_Method], 3377 "0", "Over-Current Response"); 3378 break; >>> CID 1461223: (DEADCODE) >>> Execution cannot reach this statement: "case 1:". 3379 case 1: 3380 set_vif_field(&vif_fields[PD_OCP_Method], 3381 vif_component_name[PD_OCP_Method], 3382 "1", "Under-Voltage Response"); 3383 break; 3384 case 2: /3rdparty/chromeec/util/genvif.c: 3384 in init_vif_component_pd_source_fields() 3378 break; 3379 case 1: 3380 set_vif_field(&vif_fields[PD_OCP_Method], 3381 vif_component_name[PD_OCP_Method], 3382 "1", "Under-Voltage Response"); 3383 break; >>> CID 1461223: (DEADCODE) >>> Execution cannot reach this statement: "case 2:". 3384 case 2: 3385 set_vif_field(&vif_fields[PD_OCP_Method], 3386 vif_component_name[PD_OCP_Method], 3387 "2", "Both"); 3388 break; 3389 default: ** CID 1461222: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /3rdparty/chromeec/common/motion_sense.c: 970 in motion_sense_task() ________________________________________________________________________________________________________ *** CID 1461222: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /3rdparty/chromeec/common/motion_sense.c: 970 in motion_sense_task() 964 /* 965 * Ask the host to flush the queue if 966 * - a flush event has been queued. 967 * - the queue is almost full, 968 * - we haven't done it for a while. 969 */ >>> CID 1461222: Integer handling issues (CONSTANT_EXPRESSION_RESULT) >>> "({...; 0;}) && (motion_sense_fifo_bypass_needed() || event & (768U /* (1U << 8 + 1) / !!((1U << 8 + 1) & 65535) | (1U << 8) / !!((1U << 8) & 65535) */) || motion_sense_fifo_over_thres() || (ap_event_interval > 0 && time_after(ts_begin_task.le.lo, ts_last_int.le.lo + ap_event_interval)))" is always false regardless of the values of its operands. This occurs as the logical operand of "if". 970 if (IS_ENABLED(CONFIG_ACCEL_FIFO) && 971 (motion_sense_fifo_bypass_needed() || 972 event & (TASK_EVENT_MOTION_ODR_CHANGE | 973 TASK_EVENT_MOTION_FLUSH_PENDING) || 974 motion_sense_fifo_over_thres() || 975 (ap_event_interval > 0 && ** CID 1461221: Control flow issues (DEADCODE) /3rdparty/chromeec/common/usb_pd_alt_mode_dfp.c: 1241 in svdm_dp_get_mux_mode() ________________________________________________________________________________________________________ *** CID 1461221: Control flow issues (DEADCODE) /3rdparty/chromeec/common/usb_pd_alt_mode_dfp.c: 1241 in svdm_dp_get_mux_mode() 1235 { 1236 int pin_mode = get_dp_pin_mode(port); 1237 /* Default dp_port_mf_allow is true */ 1238 int mf_pref; 1239 1240 if (IS_ENABLED(CONFIG_CMD_MFALLOW)) >>> CID 1461221: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "mf_pref" inside this statement: "mf_pref = (dp_status[port] ...". 1241 mf_pref = PD_VDO_DPSTS_MF_PREF(dp_status[port]) && 1242 dp_port_mf_allow[port]; 1243 else 1244 mf_pref = PD_VDO_DPSTS_MF_PREF(dp_status[port]); 1245 1246 /* ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

Question On External Display
by Rao G 30 Jul '21

30 Jul '21

Hi All, Hope you are doing well. Platform Baytrail Issue: Graphics External Display VBIOS/VBT data trying to see the MMIO or VBIOS data when a external display device is plugged/unplugged with DP/HDMI interface, which MMIO register is set or cleared Any inputs are appreciated, some of the registers tried on Port B/Port C are given below. when Display is connected and when Display is not connected, both these instances return the same data. Looking for register/bit that sets/clears when external display is connected/disconnected printk(BIOS_DEBUG, "Intel Gfx BAR GTTMMADR\n"); printk(BIOS_DEBUG, " DP_B %X\n", read32(bar+0x180000+0x64100)); printk(BIOS_DEBUG, " DP_C %X\n", read32(bar+0x180000+0x64200)); printk(BIOS_DEBUG, " HDMIC %X\n", read32(bar+0x180000+0x61160)); printk(BIOS_DEBUG, " HDMIB %X\n", read32(bar+0x180000+0x61140)); printk(BIOS_DEBUG, " Hotplug control %X\n", read32(bar+0x180000+0x61164)); printk(BIOS_DEBUG, " pipeA control %X\n", read32(bar+0x180000+0x61204)); printk(BIOS_DEBUG, " pipeB control %X\n", read32(bar+0x180000+0x61304)); printk(BIOS_DEBUG, " porthot plug stat %X\n", read32(bar+0x180000+0x61114)); *Display SPEC* https://01.org/sites/default/files/documentation/intel_os_gfx_prm_vol10_-_d… Thanks Rao

2 1

[RFT] Please help review and test the coreboot toolchain update to GCC 11.2
by Paul Menzel 28 Jul '21

28 Jul '21

Dear coreboot folks, Patrick prepared the GCC 11.2 for the coreboot toolchain (crossgcc) [1]. It’d be great if everybody gave it a go, and reviewed the change-sets. If somebody has a system (scripts) to compare the build artifacts of the current GCC 8.3.0 builds with GCC 11.2, it’d be awesome if these or the results could be shared. Kind regards, Paul [1]: https://review.coreboot.org/c/coreboot/+/54050 "util/crossgcc: Update gcc to 11.2"

1 0

GDB stub & bootblock dependencies (CONFIG_IDT_IN_EVERY_STAGE=y)
by Samek, Jan 26 Jul '21

26 Jul '21

Hello, I am currently developing on Intel TGLRVP-UP3, but this should be relevant for other TGL-based platforms and possibly all other that set CONFIG_IDT_IN_EVERY_STAGE=y: When I try to use the GDB stub for my debug attempts on TGL (CONFIG_GDB_STUB=y), I get the following 'undefined reference' errors during the bootblock linkage process: src/arch/x86/exception.c:225: undefined reference to `gdb_tx_byte' src/arch/x86/exception.c:225: undefined reference to `gdb_tx_byte' src/arch/x86/exception.c:225: undefined reference to `gdb_tx_byte' src/arch/x86/exception.c:230: undefined reference to `gdb_tx_flush' src/arch/x86/exception.c:230: undefined reference to `gdb_tx_flush' src/arch/x86/exception.c:230: undefined reference to `gdb_tx_flush' src/arch/x86/exception.c:235: undefined reference to `gdb_rx_byte' util/crossgcc/xgcc/bin/i386-elf-ld.bfd: src/arch/x86/exception.c:225: undefined reference to `gdb_tx_byte' util/crossgcc/xgcc/bin/i386-elf-ld.bfd: src/arch/x86/exception.c:225: undefined reference to `gdb_tx_byte' util/crossgcc/xgcc/bin/i386-elf-ld.bfd: src/arch/x86/exception.c:225: undefined reference to `gdb_tx_byte' util/crossgcc/xgcc/bin/i386-elf-ld.bfd: src/arch/x86/exception.c:225: undefined reference to `gdb_tx_byte' util/crossgcc/xgcc/bin/i386-elf-ld.bfd: src/arch/x86/exception.c:235: undefined reference to `gdb_rx_byte' util/crossgcc/xgcc/bin/i386-elf-ld.bfd: src/arch/x86/exception.c:235: undefined reference to `gdb_rx_byte' util/crossgcc/xgcc/bin/i386-elf-ld.bfd: src/arch/x86/exception.c:235: undefined reference to `gdb_rx_byte' util/crossgcc/xgcc/bin/i386-elf-ld.bfd: src/arch/x86/exception.c:235: undefined reference to `gdb_rx_byte' The gdb_*() functions used in exception.c are defined in src/console/console.c. Nevertheless, the problem with the functions in question is that they're defined under '#if CONFIG(GDB_STUB) && (ENV_ROMSTAGE || ENV_RAMSTAGE)' which obviously doesn't allow them to be compiled into the bootblock code while they're unconditionally (there's only the IDT_IN_EVERY_STAGE condition) referenced in exception.c Looking at src/arch/x86/Makefile.inc (filtering out only the lines of interest), it's apparent that exception.c is linked in all stages when the IDT_IN_EVERY_STAGE option is set: 76: bootblock-$(CONFIG_IDT_IN_EVERY_STAGE) += exception.c 111: verstage-$(CONFIG_IDT_IN_EVERY_STAGE) += exception.c 148: romstage-$(CONFIG_IDT_IN_EVERY_STAGE) += exception.c 187: postcar-$(CONFIG_IDT_IN_EVERY_STAGE) += exception.c 229: ramstage-y += exception.c 291: smm-$(CONFIG_IDT_IN_EVERY_STAGE) += exception.c The behavior appears in revision b90aba43c1405d3d2cb7cba05e68906e979dcda3 (master). To reproduce, - run 'make menuconfig', - select 'Mainboard ->Mainboard Vendor': 'Intel', - select 'Mainboard -> Mainboard Model': 'Tiger Lake UP3 RVP', - select 'Debugging -> GDB debugging support': 'y'. - run 'make'. What do you think would be the best approach to make the GDB stub work on these platforms? P.S. My bug tracker registration is currently pending an approval, I could be able to create a ticket afterwards. Regards, Jan

3 4

Re: RFC: On testing and reporting how well coreboot does on real hardware
by Daniel Kulesz 17 Jul '21

17 Jul '21

Hi Piotr, Patrick et al., actually, there is dedicated software to achieve exactly what you are talking about. I initiated the SystemTestPortal project [1] a while ago to provide an open source solution that focuses on simplicity and low entry barriers - you can watch my 2019 talk at FrOsCon [2] to get a first overview. Currently, the project is stalled and, thus, the software is ready for production due to the lack of maintenance. However I plan tp resume the project soon. There are also other open source projects that provide similar solutions in this space. Yet, I must confess that to date I had a really hard time convincing developers to give our tool a serious try. While this might be due to bugs in the tool itself, I think it is mainly because many developers and project leaders don't buy into such a "community testing" approach as they think that the only right way to test software is through test automation. I think that coreboot is a perfect example of a project that could benefit from such a tool (not necessarily our tool, but one from this category). Cheers, Daniel [1] https://www.systemtestportal.org/ [2] https://media.ccc.de/v/froscon2019-2359-testing_software_yes_please

3 3

New Defects reported by Coverity Scan for coreboot
by scan-admin＠coverity.com 16 Jul '21

16 Jul '21

Hi, Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan. 26 new defect(s) introduced to coreboot found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 20 of 26 defect(s) ** CID 1458462: Resource leaks (RESOURCE_LEAK) /util/kconfig/confdata.c: 1149 in conf_write_autoconf() ________________________________________________________________________________________________________ *** CID 1458462: Resource leaks (RESOURCE_LEAK) /util/kconfig/confdata.c: 1149 in conf_write_autoconf() 1143 return 1; 1144 1145 name = getenv("KCONFIG_AUTOHEADER"); 1146 if (!name) 1147 name = "include/generated/autoconf.h"; 1148 if (make_parent_dir(name)) >>> CID 1458462: Resource leaks (RESOURCE_LEAK) >>> Variable "out" going out of scope leaks the storage it points to. 1149 return 1; 1150 char filename_h[PATH_MAX]; 1151 int fd_h = conf_mktemp(name, filename_h); 1152 if (fd_h == -1) 1153 return 1; 1154 out_h = fdopen(fd_h, "w"); ** CID 1458461: Resource leaks (RESOURCE_LEAK) /util/kconfig/menu.c: 212 in menu_add_symbol() ________________________________________________________________________________________________________ *** CID 1458461: Resource leaks (RESOURCE_LEAK) /util/kconfig/menu.c: 212 in menu_add_symbol() 206 { 207 menu_add_prop(type, expr, dep); 208 } 209 210 void menu_add_symbol(enum prop_type type, struct symbol *sym, struct expr *dep) 211 { >>> CID 1458461: Resource leaks (RESOURCE_LEAK) >>> Ignoring storage allocated by "menu_add_prop(type, expr_alloc_symbol(sym), dep)" leaks it. 212 menu_add_prop(type, expr_alloc_symbol(sym), dep); 213 } 214 215 static int menu_validate_number(struct symbol *sym, struct symbol *sym2) 216 { 217 return sym2->type == S_INT || sym2->type == S_HEX || ** CID 1458460: Security best practices violations (STRING_OVERFLOW) /util/kconfig/confdata.c: 1049 in conf_touch_deps() ________________________________________________________________________________________________________ *** CID 1458460: Security best practices violations (STRING_OVERFLOW) /util/kconfig/confdata.c: 1049 in conf_touch_deps() 1043 static int conf_touch_deps(void) 1044 { 1045 const char *name; 1046 struct symbol *sym; 1047 int res, i; 1048 >>> CID 1458460: Security best practices violations (STRING_OVERFLOW) >>> You might overrun the 4096-character fixed-size string "depfile_path" by copying the return value of "conf_get_autobase_name" without checking the length. 1049 strcpy(depfile_path, conf_get_autobase_name()); 1050 depfile_prefix_len = strlen(depfile_path); 1051 1052 name = conf_get_autoconfig_name(); 1053 conf_read_simple(name, S_DEF_AUTO); 1054 sym_calc_value(modules_sym); ** CID 1458459: Resource leaks (RESOURCE_LEAK) /util/kconfig/menu.c: 207 in menu_add_expr() ________________________________________________________________________________________________________ *** CID 1458459: Resource leaks (RESOURCE_LEAK) /util/kconfig/menu.c: 207 in menu_add_expr() 201 current_entry->visibility = expr_alloc_and(current_entry->visibility, 202 expr); 203 } 204 205 void menu_add_expr(enum prop_type type, struct expr *expr, struct expr *dep) 206 { >>> CID 1458459: Resource leaks (RESOURCE_LEAK) >>> Ignoring storage allocated by "menu_add_prop(type, expr, dep)" leaks it. 207 menu_add_prop(type, expr, dep); 208 } 209 210 void menu_add_symbol(enum prop_type type, struct symbol *sym, struct expr *dep) 211 { 212 menu_add_prop(type, expr_alloc_symbol(sym), dep); ** CID 1458458: Null pointer dereferences (FORWARD_NULL) /util/kconfig/menu.c: 820 in get_symbol_str() ________________________________________________________________________________________________________ *** CID 1458458: Null pointer dereferences (FORWARD_NULL) /util/kconfig/menu.c: 820 in get_symbol_str() 814 str_append(r, "\n"); 815 } 816 } 817 } 818 819 /* Print the definitions with prompts before the ones without */ >>> CID 1458458: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "sym". 820 for_all_properties(sym, prop, P_SYMBOL) { 821 if (prop->menu->prompt) { 822 get_def_str(r, prop->menu); 823 get_prompt_str(r, prop->menu->prompt, head); 824 } 825 } ** CID 1458457: Security best practices violations (SECURE_TEMP) /util/kconfig/confdata.c: 890 in conf_mktemp() ________________________________________________________________________________________________________ *** CID 1458457: Security best practices violations (SECURE_TEMP) /util/kconfig/confdata.c: 890 in conf_mktemp() 884 static int conf_mktemp(const char *path, char *tmpfile) 885 { 886 if (snprintf(tmpfile, PATH_MAX, "%s.tmp.XXXXXX", path) >= PATH_MAX) { 887 errno = EOVERFLOW; 888 return -1; 889 } >>> CID 1458457: Security best practices violations (SECURE_TEMP) >>> Calling "mkstemp" without securely setting umask first. 890 return mkstemp(tmpfile); 891 } 892 893 int conf_write(const char *name) 894 { 895 FILE *out; ** CID 1425175: Resource leaks (RESOURCE_LEAK) /util/kconfig/confdata.c: 84 in is_same() ________________________________________________________________________________________________________ *** CID 1425175: Resource leaks (RESOURCE_LEAK) /util/kconfig/confdata.c: 84 in is_same() 78 ret = true; 79 close2: 80 close(fd2); 81 close1: 82 close(fd1); 83 >>> CID 1425175: Resource leaks (RESOURCE_LEAK) >>> Variable "map1" going out of scope leaks the storage it points to. 84 return ret; 85 } 86 87 /* 88 * Create the parent directory of the given path. 89 * ** CID 1425144: Null pointer dereferences (FORWARD_NULL) /util/kconfig/symbol.c: 1078 in sym_check_print_recursive() ________________________________________________________________________________________________________ *** CID 1425144: Null pointer dereferences (FORWARD_NULL) /util/kconfig/symbol.c: 1078 in sym_check_print_recursive() 1072 menu = prop->menu; 1073 if (prop->menu) 1074 break; 1075 } 1076 } 1077 if (stack->sym == last_sym) >>> CID 1425144: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "prop". 1078 fprintf(stderr, "%s:%d:error: recursive dependency detected!\n", 1079 prop->file->name, prop->lineno); 1080 1081 if (sym_is_choice(sym)) { 1082 fprintf(stderr, "%s:%d:\tchoice %s contains symbol %s\n", 1083 menu->file->name, menu->lineno, ** CID 1425116: (TAINTED_SCALAR) ________________________________________________________________________________________________________ *** CID 1425116: (TAINTED_SCALAR) /util/kconfig/confdata.c: 1130 in conf_write_autoconf() 1124 if (!overwrite && is_present(autoconf_name)) 1125 return 0; 1126 1127 char autoconfcmd_path[PATH_MAX]; 1128 snprintf(autoconfcmd_path, sizeof(autoconfcmd_path), "%s%s", 1129 conf_get_autobase_name(), "auto.conf.cmd"); >>> CID 1425116: (TAINTED_SCALAR) >>> Passing tainted variable "autoconfcmd_path" to a tainted sink. 1130 conf_write_dep(autoconfcmd_path); 1131 1132 if (conf_touch_deps()) 1133 return 1; 1134 1135 if (make_parent_dir(autoconf_name)) /util/kconfig/confdata.c: 1148 in conf_write_autoconf() 1142 if (!out) 1143 return 1; 1144 1145 name = getenv("KCONFIG_AUTOHEADER"); 1146 if (!name) 1147 name = "include/generated/autoconf.h"; >>> CID 1425116: (TAINTED_SCALAR) >>> Passing tainted variable "name" to a tainted sink. 1148 if (make_parent_dir(name)) 1149 return 1; 1150 char filename_h[PATH_MAX]; 1151 int fd_h = conf_mktemp(name, filename_h); 1152 if (fd_h == -1) 1153 return 1; /util/kconfig/confdata.c: 1135 in conf_write_autoconf() 1129 conf_get_autobase_name(), "auto.conf.cmd"); 1130 conf_write_dep(autoconfcmd_path); 1131 1132 if (conf_touch_deps()) 1133 return 1; 1134 >>> CID 1425116: (TAINTED_SCALAR) >>> Passing tainted variable "autoconf_name" to a tainted sink. 1135 if (make_parent_dir(autoconf_name)) 1136 return 1; 1137 char filename[PATH_MAX]; 1138 int fd = conf_mktemp(autoconf_name, filename); 1139 if (fd == -1) 1140 return 1; ** CID 1425106: Resource leaks (RESOURCE_LEAK) /util/kconfig/confdata.c: 84 in is_same() ________________________________________________________________________________________________________ *** CID 1425106: Resource leaks (RESOURCE_LEAK) /util/kconfig/confdata.c: 84 in is_same() 78 ret = true; 79 close2: 80 close(fd2); 81 close1: 82 close(fd1); 83 >>> CID 1425106: Resource leaks (RESOURCE_LEAK) >>> Variable "map2" going out of scope leaks the storage it points to. 84 return ret; 85 } 86 87 /* 88 * Create the parent directory of the given path. 89 * ** CID 1425096: Insecure data handling (TAINTED_SCALAR) ________________________________________________________________________________________________________ *** CID 1425096: Insecure data handling (TAINTED_SCALAR) /util/kconfig/confdata.c: 917 in conf_write() 911 912 if (is_dir(name)) { 913 fprintf(stderr, "%s: Is a directory\n", name); 914 return -1; 915 } 916 >>> CID 1425096: Insecure data handling (TAINTED_SCALAR) >>> Passing tainted variable "name" to a tainted sink. 917 if (make_parent_dir(name)) 918 return -1; 919 920 env = getenv("KCONFIG_OVERWRITECONFIG"); 921 if (env && *env) { 922 *tmpname = 0; ** CID 1425085: Incorrect expression (COPY_PASTE_ERROR) /util/kconfig/expr.c: 537 in expr_join_and() ________________________________________________________________________________________________________ *** CID 1425085: Incorrect expression (COPY_PASTE_ERROR) /util/kconfig/expr.c: 537 in expr_join_and() 531 // (a) && (a!='n') -> (a) 532 return expr_alloc_symbol(sym1); 533 534 if ((e1->type == E_SYMBOL && e2->type == E_UNEQUAL && e2->right.sym == &symbol_mod) || 535 (e2->type == E_SYMBOL && e1->type == E_UNEQUAL && e1->right.sym == &symbol_mod)) 536 // (a) && (a!='m') -> (a='y') >>> CID 1425085: Incorrect expression (COPY_PASTE_ERROR) >>> "symbol_yes" in "&symbol_yes" looks like a copy-paste error. 537 return expr_alloc_comp(E_EQUAL, sym1, &symbol_yes); 538 539 if (sym1->type == S_TRISTATE) { 540 if (e1->type == E_EQUAL && e2->type == E_UNEQUAL) { 541 // (a='b') && (a!='c') -> 'b'='c' ? 'n' : a='b' 542 sym2 = e1->right.sym; ** CID 1425081: Control flow issues (MISSING_BREAK) /util/kconfig/expr.c: 1112 in expr_compare_type() ________________________________________________________________________________________________________ *** CID 1425081: Control flow issues (MISSING_BREAK) /util/kconfig/expr.c: 1112 in expr_compare_type() 1106 if (t1 == t2) 1107 return 0; 1108 switch (t1) { 1109 case E_LEQ: 1110 case E_LTH: 1111 case E_GEQ: >>> CID 1425081: Control flow issues (MISSING_BREAK) >>> The case for value "E_GTH" is not terminated by a 'break' statement. 1112 case E_GTH: 1113 if (t2 == E_EQUAL || t2 == E_UNEQUAL) 1114 return 1; 1115 case E_EQUAL: 1116 case E_UNEQUAL: 1117 if (t2 == E_NOT) ** CID 1425079: Control flow issues (UNREACHABLE) /util/kconfig/expr.c: 1134 in expr_compare_type() ________________________________________________________________________________________________________ *** CID 1425079: Control flow issues (UNREACHABLE) /util/kconfig/expr.c: 1134 in expr_compare_type() 1128 case E_LIST: 1129 if (t2 == 0) 1130 return 1; 1131 default: 1132 return -1; 1133 } >>> CID 1425079: Control flow issues (UNREACHABLE) >>> This code cannot be reached: "printf("[%dgt%d?]", t1, t2);". 1134 printf("[%dgt%d?]", t1, t2); 1135 return 0; 1136 } 1137 1138 void expr_print(struct expr *e, 1139 void (*fn)(void *, struct symbol *, const char *), ** CID 1425063: Null pointer dereferences (REVERSE_INULL) /util/kconfig/confdata.c: 526 in conf_read_simple() ________________________________________________________________________________________________________ *** CID 1425063: Null pointer dereferences (REVERSE_INULL) /util/kconfig/confdata.c: 526 in conf_read_simple() 520 conf_warning("unexpected data: %.*s", 521 (int)strcspn(line, "\r\n"), line); 522 523 continue; 524 } 525 >>> CID 1425063: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "sym" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 526 if (sym && sym_is_choice_value(sym)) { 527 struct symbol *cs = prop_get_symbol(sym_get_choice_prop(sym)); 528 switch (sym->def[def].tri) { 529 case no: 530 break; 531 case mod: ** CID 1425039: Error handling issues (CHECKED_RETURN) /util/kconfig/confdata.c: 1039 in conf_write_dep() ________________________________________________________________________________________________________ *** CID 1425039: Error handling issues (CHECKED_RETURN) /util/kconfig/confdata.c: 1039 in conf_write_dep() 1033 1034 env_write_dep(out, conf_get_autoconfig_name()); 1035 1036 fprintf(out, "\n$(deps_config): ;\n"); 1037 fclose(out); 1038 >>> CID 1425039: Error handling issues (CHECKED_RETURN) >>> Calling "rename(filename, name)" without checking return value. This library function may fail and return an error code. 1039 rename(filename, name); 1040 return 0; 1041 } 1042 1043 static int conf_touch_deps(void) 1044 { ** CID 1425010: Security best practices violations (DC.WEAK_CRYPTO) /util/kconfig/conf.c: 251 in conf_set_all_new_symbols() ________________________________________________________________________________________________________ *** CID 1425010: Security best practices violations (DC.WEAK_CRYPTO) /util/kconfig/conf.c: 251 in conf_set_all_new_symbols() 245 break; 246 case def_no: 247 sym->def[S_DEF_USER].tri = no; 248 break; 249 case def_random: 250 sym->def[S_DEF_USER].tri = no; >>> CID 1425010: Security best practices violations (DC.WEAK_CRYPTO) >>> "rand" should not be used for security-related applications, because linear congruential algorithms are too easy to break. 251 cnt = rand() % 100; 252 if (sym->type == S_TRISTATE) { 253 if (cnt < pty) 254 sym->def[S_DEF_USER].tri = yes; 255 else if (cnt < pty + ptm) 256 sym->def[S_DEF_USER].tri = mod; ** CID 1425007: (RESOURCE_LEAK) /util/kconfig/expr.c: 949 in expr_trans_compare() /util/kconfig/expr.c: 939 in expr_trans_compare() ________________________________________________________________________________________________________ *** CID 1425007: (RESOURCE_LEAK) /util/kconfig/expr.c: 949 in expr_trans_compare() 943 case E_OR: 944 e1 = expr_trans_compare(e->left.expr, E_EQUAL, sym); 945 e2 = expr_trans_compare(e->right.expr, E_EQUAL, sym); 946 if (sym == &symbol_yes) 947 e = expr_alloc_two(E_OR, e1, e2); 948 if (sym == &symbol_no) >>> CID 1425007: (RESOURCE_LEAK) >>> Overwriting "e" in "e = expr_alloc_two(E_AND, e1, e2)" leaks the storage that "e" points to. 949 e = expr_alloc_two(E_AND, e1, e2); 950 if (type == E_UNEQUAL) 951 e = expr_alloc_one(E_NOT, e); 952 return e; 953 case E_NOT: 954 return expr_trans_compare(e->left.expr, type == E_EQUAL ? E_UNEQUAL : E_EQUAL, sym); /util/kconfig/expr.c: 939 in expr_trans_compare() 933 case E_AND: 934 e1 = expr_trans_compare(e->left.expr, E_EQUAL, sym); 935 e2 = expr_trans_compare(e->right.expr, E_EQUAL, sym); 936 if (sym == &symbol_yes) 937 e = expr_alloc_two(E_AND, e1, e2); 938 if (sym == &symbol_no) >>> CID 1425007: (RESOURCE_LEAK) >>> Overwriting "e" in "e = expr_alloc_two(E_OR, e1, e2)" leaks the storage that "e" points to. 939 e = expr_alloc_two(E_OR, e1, e2); 940 if (type == E_UNEQUAL) 941 e = expr_alloc_one(E_NOT, e); 942 return e; 943 case E_OR: 944 e1 = expr_trans_compare(e->left.expr, E_EQUAL, sym); ** CID 1424942: (REVERSE_INULL) /payloads/coreinfo/build/util/kconfig/lexer.lex.c: 4017 in zconf_fopen() /payloads/coreinfo/libpayload/util/lp_kconfig/lexer.lex.c: 4017 in zconf_fopen() /payloads/libpayload/build/util/lp_kconfig/lexer.lex.c: 4017 in zconf_fopen() /cb-build/coreboot-coverity.0/default/sharedutils/kconfig/lexer.lex.c: 4017 in zconf_fopen() /build/util/kconfig/lexer.lex.c: 4017 in zconf_fopen() /cb-build/coreboot-coverity.0/chromeos/sharedutils/kconfig/lexer.lex.c: 4017 in zconf_fopen() /payloads/nvramcui/libpayload/util/lp_kconfig/lexer.lex.c: 4017 in zconf_fopen() ________________________________________________________________________________________________________ *** CID 1424942: (REVERSE_INULL) /payloads/coreinfo/build/util/kconfig/lexer.lex.c: 4017 in zconf_fopen() 4011 FILE *zconf_fopen(const char *name) 4012 { 4013 char *env, fullname[PATH_MAX+1]; 4014 FILE *f; 4015 4016 f = fopen(name, "r"); >>> CID 1424942: (REVERSE_INULL) >>> Null-checking "name" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 4017 if (!f && name != NULL && name[0] != '/') { 4018 env = getenv(SRCTREE); 4019 if (env) { 4020 snprintf(fullname, sizeof(fullname), 4021 "%s/%s", env, name); 4022 f = fopen(fullname, "r"); /payloads/coreinfo/libpayload/util/lp_kconfig/lexer.lex.c: 4017 in zconf_fopen() 4011 FILE *zconf_fopen(const char *name) 4012 { 4013 char *env, fullname[PATH_MAX+1]; 4014 FILE *f; 4015 4016 f = fopen(name, "r"); >>> CID 1424942: (REVERSE_INULL) >>> Null-checking "name" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 4017 if (!f && name != NULL && name[0] != '/') { 4018 env = getenv(SRCTREE); 4019 if (env) { 4020 snprintf(fullname, sizeof(fullname), 4021 "%s/%s", env, name); 4022 f = fopen(fullname, "r"); /payloads/libpayload/build/util/lp_kconfig/lexer.lex.c: 4017 in zconf_fopen() 4011 FILE *zconf_fopen(const char *name) 4012 { 4013 char *env, fullname[PATH_MAX+1]; 4014 FILE *f; 4015 4016 f = fopen(name, "r"); >>> CID 1424942: (REVERSE_INULL) >>> Null-checking "name" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 4017 if (!f && name != NULL && name[0] != '/') { 4018 env = getenv(SRCTREE); 4019 if (env) { 4020 snprintf(fullname, sizeof(fullname), 4021 "%s/%s", env, name); 4022 f = fopen(fullname, "r"); /cb-build/coreboot-coverity.0/default/sharedutils/kconfig/lexer.lex.c: 4017 in zconf_fopen() 4011 FILE *zconf_fopen(const char *name) 4012 { 4013 char *env, fullname[PATH_MAX+1]; 4014 FILE *f; 4015 4016 f = fopen(name, "r"); >>> CID 1424942: (REVERSE_INULL) >>> Null-checking "name" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 4017 if (!f && name != NULL && name[0] != '/') { 4018 env = getenv(SRCTREE); 4019 if (env) { 4020 snprintf(fullname, sizeof(fullname), 4021 "%s/%s", env, name); 4022 f = fopen(fullname, "r"); /build/util/kconfig/lexer.lex.c: 4017 in zconf_fopen() 4011 FILE *zconf_fopen(const char *name) 4012 { 4013 char *env, fullname[PATH_MAX+1]; 4014 FILE *f; 4015 4016 f = fopen(name, "r"); >>> CID 1424942: (REVERSE_INULL) >>> Null-checking "name" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 4017 if (!f && name != NULL && name[0] != '/') { 4018 env = getenv(SRCTREE); 4019 if (env) { 4020 snprintf(fullname, sizeof(fullname), 4021 "%s/%s", env, name); 4022 f = fopen(fullname, "r"); /cb-build/coreboot-coverity.0/chromeos/sharedutils/kconfig/lexer.lex.c: 4017 in zconf_fopen() 4011 FILE *zconf_fopen(const char *name) 4012 { 4013 char *env, fullname[PATH_MAX+1]; 4014 FILE *f; 4015 4016 f = fopen(name, "r"); >>> CID 1424942: (REVERSE_INULL) >>> Null-checking "name" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 4017 if (!f && name != NULL && name[0] != '/') { 4018 env = getenv(SRCTREE); 4019 if (env) { 4020 snprintf(fullname, sizeof(fullname), 4021 "%s/%s", env, name); 4022 f = fopen(fullname, "r"); /payloads/nvramcui/libpayload/util/lp_kconfig/lexer.lex.c: 4017 in zconf_fopen() 4011 FILE *zconf_fopen(const char *name) 4012 { 4013 char *env, fullname[PATH_MAX+1]; 4014 FILE *f; 4015 4016 f = fopen(name, "r"); >>> CID 1424942: (REVERSE_INULL) >>> Null-checking "name" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 4017 if (!f && name != NULL && name[0] != '/') { 4018 env = getenv(SRCTREE); 4019 if (env) { 4020 snprintf(fullname, sizeof(fullname), 4021 "%s/%s", env, name); 4022 f = fopen(fullname, "r"); ** CID 1424938: Control flow issues (MISSING_BREAK) /util/kconfig/expr.c: 1125 in expr_compare_type() ________________________________________________________________________________________________________ *** CID 1424938: Control flow issues (MISSING_BREAK) /util/kconfig/expr.c: 1125 in expr_compare_type() 1119 case E_NOT: 1120 if (t2 == E_AND) 1121 return 1; 1122 case E_AND: 1123 if (t2 == E_OR) 1124 return 1; >>> CID 1424938: Control flow issues (MISSING_BREAK) >>> The case for value "E_OR" is not terminated by a 'break' statement. 1125 case E_OR: 1126 if (t2 == E_LIST) 1127 return 1; 1128 case E_LIST: 1129 if (t2 == 0) 1130 return 1; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P…

1 0

RFC: On testing and reporting how well coreboot does on real hardware
by Patrick Georgi 15 Jul '21

15 Jul '21

Hi everybody, There has been some talk recently in a smaller group where coreboot needs to improve the most in public perception, and how to get there. Consensus has been that we're doing a pretty bad job at promoting all the hardware that we support in each coreboot version. There's board-status which I started _years_ ago in the hope that somebody picks up the slack, but everybody has been busy, myself included. By now the collected information of the last 7.5 years is compiled into a 12MB HTML file that takes ages to render on moderate hardware (beware: https://www.coreboot.org/status/board-status.html), and the process to collect that data is mostly manual using pretty poor tooling. (Most of the links on that page don't even work anymore (which I'll fix) due to gitweb/cgit/gitiles changes on review.coreboot.org (and I only noticed by chance now).) Meanwhile, there are several parties that boot test the hardware they care about regularly, with (often internal) information about how well coreboot does there. We can't expect all those existing systems to converge into a single testing framework, but we could make it a single test result reporting framework. To this end, I invite people interested in that topic to chime in on this email thread so that we can discuss what we could do to provide a common place with information about which coreboot versions are bootable on which boards in a way that makes sense for everybody: users who are interested in such data as well as testers that already collect it but have no way to publish it. Thanks, Patrick -- Google Germany GmbH, ABC-Str. 19, 20354 Hamburg Registergericht und -nummer: Hamburg, HRB 86891, Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

4 4

Adding support for asynchronous operations
by Raul Rangel 15 Jul '21

15 Jul '21

Hello coreboot community, One of coreboot's goals (according to the home page) is to be lightning fast! I'm currently working on improving the boot time for the AMD Cezanne platform. One place where we spend a decent amount of time is reading from SPI flash. We have the SPI speed/modes set to the optimal settings for our platforms, but there is still room for improvement. One feature the AMD platforms provide is a SPI DMA controller. It allows performing upto 64 KiB reads from SPI to RAM without the CPU being involved. This opens up the door for parallelizing SPI reads and coreboot execution. This effectively makes SPI read times 0 as far as the BSP is concerned (assuming you can preload early enough). Another difference between the latest AMD SoCs (Picasso, Cezanne), is that RAM is available in bootblock. This means that we can preload compressed stages into RAM before they are required. This will require a larger RAM footprint. The question is, how do we model these asynchronous operations, how is data ownership handled, and how does the BSP know the operation is done? I have proposed a Futures API [here](https://review.coreboot.org/c/coreboot/+/56047) that I think addresses all the questions. I think it is simple to understand, hard for consumers to misuse, and pretty straightforward to implement. The patch train also contains adding a `readat_async` to `rdev`, adding `cbfs_load_async`, APOB (i.e., MRC) preloading, and compressed payload preloading. This so far has saved over 30ms. I still have the goal of preloading the VBIOS, uCode, and ramstage. I want to do all of this while adding minimal complexity to the synchronous path. I'm curious to see what the community thinks, and welcome any feedback. Thanks, Raul

3 5

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot