[S] Change in coreboot[master]: device/pci_rom: Set VBIOS checksum when filling VFCT table
Attention is currently required from: CoolStar, Martin L Roth, Paul Menzel.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77628?usp=email )
Change subject: device/pci_rom: Set VBIOS checksum when filling VFCT table ......................................................................
Patch Set 1:
(3 comments)
File src/device/pci_rom.c:
https://review.coreboot.org/c/coreboot/+/77628/comment/3eed7542_55395b72 : PS1, Line 221: #define ATOMBIOS_CHECKSUM_OFFSET 0x21
Would it make more sense to put this in a header file like acpi/acpi. […]
will do
https://review.coreboot.org/c/coreboot/+/77628/comment/399f711d_2e8871f4 : PS1, Line 254: /* Calculate checksum for VBIOS data. */
I don't think that this is something that can be done universally. […]
acpi_create_vfct(), which calls pci_rom_acpi_fill_vfct(), is only called on VGA oproms with a VID = PCI_VID_ATI, so Intel ones won't be touched. I actually did test this on Zork (running VBIOS, not GOP) and no problem there. But if preferred, would guarding this with CONFIG(RUN_FSP_GOP) suffice?
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/77628/comment/f16f03c5_d56e4be0 : PS1, Line 481: VbiosContent[1]
We're actually getting rid of all 0 & 1 length arrays in coreboot right now. […]
will do
-
Matt DeVillier (Code Review)