[M] Change in coreboot[main]: drivers/intel/fsp2_0: Add option to control debug log level using CBFS

[Subrata Banik (Code Review)]

Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Julius Werner, Jérémy Compostella, Ronak Kanabar.

Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86001?usp=email )

Change subject: drivers/intel/fsp2_0: Add option to control debug log level using CBFS
......................................................................

Patch Set 5:

(5 comments)

File src/drivers/intel/fsp2_0/Kconfig:

https://review.coreboot.org/c/coreboot/+/86001/comment/38a18fab_cd5dd6d7?usp... :
PS5, Line 528: 	default n
> unnecessary default, n is default for boolean.

Acknowledged

https://review.coreboot.org/c/coreboot/+/86001/comment/d9df26b6_2b3cd6d9?usp... :
PS5, Line 537: 	  Here is the example of adding RAW binary file into the RO-CBFS to specify the
> Here is **an** example

Acknowledged

File src/drivers/intel/fsp2_0/debug.c:

https://review.coreboot.org/c/coreboot/+/86001/comment/4c38703c_e3a294b0?usp... :
PS5, Line 183: enum fsp_log_level get_fsp_pcd_debug_log_level(void)
> All fsp helper function are prefixed with fsp, shouldn't we write it fsp_get_pcd_debug_log_level() ?

Acknowledged

https://review.coreboot.org/c/coreboot/+/86001/comment/6c449960_48d4d3d6?usp... :
PS5, Line 185: 	if (!CONFIG(FSP_DEBUG_LOG_LEVEL_USING_CBFS))
> This should be called USING_OPTIONS or something like that, since it would work with other option ba […]

Acknowledged

File src/drivers/intel/fsp2_0/include/fsp/debug.h:

https://review.coreboot.org/c/coreboot/+/86001/comment/aad4d076_331da203?usp... :
PS5, Line 69: If `fsp_pcd_debug_level` not present
> If `fsp_pcd_debug_level` file is not present

Acknowledged