Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Paul Menzel, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79330?usp=email )
Change subject: mb/google/rex/var/screebo: Override power limits ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79330/comment/35a93503_49eaf1b4 : PS3, Line 21: [INFO ] Overriding power limits PL1 (mW) (10000, 15000) : PL2 (mW) (40000, 40000) PL4 (W) (84) : : After: : : [INFO ] Overriding power limits PL1 (mW) (10000, 15000) : PL2 (mW) (40000, 40000) PL4 (W) (84)
Thank you for the explanation. So, the paste demonstrate that the debug line is gone?
exactly the `DEBUG` line suggests that, we were using baseline default value (aka no override). And modified CL shows that we are using an overridden value from variant directory.
I was confused by “This patch modifies the power limits value to enhance …” in the beginning. But no power limits are changed?
updated the commit msg.
marking the commit resolve, please let me know if you think otherwise
i'm landing this CL because the tot is broken now, looks like because of out of order merge