Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian, Mark Hasemeyer.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74110 )
Change subject: mb/google/myst: Add eSPI configuration ......................................................................
Patch Set 14:
(2 comments)
File src/mainboard/google/myst/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74110/comment/46ebadd9_8a865446 PS6, Line 29: .op_freq_mhz = ESPI_OP_FREQ_33_MHZ,
Done
Please add a TODO(b/276913952) to bump this back up to 33MHz once things seem to be working well.
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/74110/comment/d41fe30f_7755c280 PS14, Line 216: __weak void variant_override_gpio_table(const struct soc_amd_gpio **gpio, size_t *size) This already existed in a prior CL:
https://review.coreboot.org/c/coreboot/+/74094/6/src/mainboard/google/myst/v...
Rather than re-adding it here, please find where it got lost and fix that error.
-
Tim Van Patten (Code Review)