Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45002 )
Change subject: soc/intel/{cnl,skl}: Add alignment check for TSEG base and size ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45002/4/src/soc/intel/cannonlake/sm... File src/soc/intel/cannonlake/smmrelocate.c:
https://review.coreboot.org/c/coreboot/+/45002/4/src/soc/intel/cannonlake/sm... PS4, Line 21: probably commonlib/helpers.h missing
https://review.coreboot.org/c/coreboot/+/45002/4/src/soc/intel/cannonlake/sm... PS4, Line 157: _WARNING, : "TSEG base not al fits in one line
https://review.coreboot.org/c/coreboot/+/45002/4/src/soc/intel/skylake/smmre... File src/soc/intel/skylake/smmrelocate.c:
https://review.coreboot.org/c/coreboot/+/45002/4/src/soc/intel/skylake/smmre... PS4, Line 21: probably commonlib/helpers.h missing
https://review.coreboot.org/c/coreboot/+/45002/4/src/soc/intel/skylake/smmre... PS4, Line 157: _WARNING, : "TSEG base not aligned with TSEG SIZE! Not setting SMRR\n"); fits in one line