Attention is currently required from: Subrata Banik, Jeremy Compostella, Kapil Porwal, Angel Pons.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71265 )
Change subject: drivers/pc80/vga: Add API to write multi-line video message
......................................................................
Patch Set 7: Code-Review+2
(2 comments)
File src/include/pc80/vga.h:
https://review.coreboot.org/c/coreboot/+/71265/comment/9186cfc7_af0e7959
PS6, Line 11: #define VGA_TEXT_HORIZONTAL_TOP 0
are these used anywhere? […]
got it. make sense.
https://review.coreboot.org/c/coreboot/+/71265/comment/fc40f3f7_afd45f81
PS6, Line 12: #define VGA_TEXT_HORIZONTAL_MIDDLE (VGA_LINES / 2)
are these used anywhere? […]
got it. make sense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71265
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib837e4deeba9b84038a91c93a68f03cee3474f9b
Gerrit-Change-Number: 71265
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jeremy Compostella
jeremy.compostella@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 31 Dec 2022 14:25:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment