Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60782 )
Change subject: mb/google/guybrush/var/dewatt: Update unused GPIO pins ......................................................................
Patch Set 2:
(64 comments)
File src/mainboard/google/guybrush/variants/dewatt/gpio.c:
https://review.coreboot.org/c/coreboot/+/60782/comment/aba81323_b449ad84 PS1, Line 16: /* Unused TP245*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/38c5f0b8_c25912c0 PS1, Line 17: PAD_NC(GPIO_8),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/38e952e9_06b0724b PS1, Line 17: PAD_NC(GPIO_8),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/440606b6_0eca28a1 PS1, Line 18: /* Unused TP244*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/00cb2a99_ca044a3e PS1, Line 19: PAD_NC(GPIO_11),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/59df1b3c_75793b94 PS1, Line 19: PAD_NC(GPIO_11),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/603c8ad1_9d4c8b2a PS1, Line 20: /* Unused TP194*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/673e1a82_32518038 PS1, Line 21: PAD_NC(GPIO_17),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/0f9b89dd_a8e39432 PS1, Line 21: PAD_NC(GPIO_17),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/40055289_a7e0653a PS1, Line 22: /* Unused TP195*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/1235ce09_d55a575c PS1, Line 23: PAD_NC(GPIO_18),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/5528d417_9d14db19 PS1, Line 23: PAD_NC(GPIO_18),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/9ea0cbe1_7173aa91 PS1, Line 24: /* Unused TP243*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/c8f053b9_01e3bca6 PS1, Line 25: PAD_NC(GPIO_21),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/4d5720ef_37f35022 PS1, Line 25: PAD_NC(GPIO_21),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/6249636d_6b42c787 PS1, Line 26: /* Unused TP196*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/20366341_ce872022 PS1, Line 27: PAD_NC(GPIO_24),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/2a244ebc_60f8d6b9 PS1, Line 27: PAD_NC(GPIO_24),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/8d7036d2_d31dfde9 PS1, Line 28: /* Unused TP219*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/f716ce4a_e383695b PS1, Line 29: PAD_NC(GPIO_42),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/e065382f_7b218949 PS1, Line 29: PAD_NC(GPIO_42),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/1efde437_0defa7db PS1, Line 30: /* Unused TP217*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/46e0cda5_5fbd09ef PS1, Line 31: PAD_NC(GPIO_69),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/649288d9_6ee20abd PS1, Line 31: PAD_NC(GPIO_69),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/56ea35a7_b6544a38 PS1, Line 32: /* Unused TP235*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/35305bb5_1fe06245 PS1, Line 33: PAD_NC(GPIO_115),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/16089475_c2f3709e PS1, Line 33: PAD_NC(GPIO_115),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/bb135a4c_eedf714a PS1, Line 34: /* Unused TP205*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/c7cd7386_76a7f3d6 PS1, Line 35: PAD_NC(GPIO_116),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/c37a1b17_93f0fcf1 PS1, Line 35: PAD_NC(GPIO_116),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/d7e2157c_5b1fd77e PS1, Line 36: /* Unused TP226*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/7f7184ea_d8e171f6 PS1, Line 37: PAD_NC(GPIO_140),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/992f6863_440b1343 PS1, Line 37: PAD_NC(GPIO_140),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/b9aa93c4_1ae4c891 PS1, Line 38: /* Unused TP225*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/0b84673b_8129936e PS1, Line 39: PAD_NC(GPIO_142),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/08ad8169_22eca89b PS1, Line 39: PAD_NC(GPIO_142),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/7533c4f1_db53254e PS1, Line 40: /* Unused TP227*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/d166d108_277bc97e PS1, Line 41: PAD_NC(GPIO_144),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/889d0250_8f4097fe PS1, Line 41: PAD_NC(GPIO_144),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/27cd37e5_edb45f89 PS1, Line 45: /* Unused TP245*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/ac4d68db_40835a5e PS1, Line 46: PAD_NC(GPIO_8),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/bef1131f_ce244594 PS1, Line 46: PAD_NC(GPIO_8),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/6dcac36d_8d037905 PS1, Line 47: /* Unused TP195*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/ba7916cb_4bf52ef3 PS1, Line 48: PAD_NC(GPIO_18),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/33f73698_8c5a0bd7 PS1, Line 48: PAD_NC(GPIO_18),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/d776a184_af230b90 PS1, Line 49: /* Unused TP196*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/11640c4c_5053374e PS1, Line 50: PAD_NC(GPIO_24),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/8b4aef39_b4372b46 PS1, Line 50: PAD_NC(GPIO_24),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/9ff835f3_2aa920ee PS1, Line 51: /* Unused TP217*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/a6923f9d_3e7ad572 PS1, Line 52: PAD_NC(GPIO_69),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/c381ae1a_bd939a67 PS1, Line 52: PAD_NC(GPIO_69),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/8330522b_d5eac492 PS1, Line 57: /* Unused TP195*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/d663a849_84b71c5b PS1, Line 58: PAD_NC(GPIO_18),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/01f12365_8c2e7aaa PS1, Line 58: PAD_NC(GPIO_18),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/7bf30ac9_2bae8551 PS1, Line 59: /* Unused TP217*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/3e905ad0_94a9af9e PS1, Line 60: PAD_NC(GPIO_69),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/cf8472a4_557beb66 PS1, Line 60: PAD_NC(GPIO_69),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/704c92f2_63b9ec48 PS1, Line 65: /* Unused TP196*/
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/ddb661d3_09ef3346 PS1, Line 66: PAD_NC(GPIO_24),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/aba9b5cc_9f679880 PS1, Line 66: PAD_NC(GPIO_24),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/c123b4f7_3c40c82f PS1, Line 89: *size = ARRAY_SIZE(bootblock_gpio_table);
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/ad870406_232cf98a PS1, Line 89: *size = ARRAY_SIZE(bootblock_gpio_table);
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/da39c7e0_6d931824 PS1, Line 90: return override_bootblock_gpio_table;
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/60782/comment/92854845_c9fa3096 PS1, Line 90: return override_bootblock_gpio_table;
code indent should use tabs where possible
Please fix.
-
Kenneth Chan (Code Review)