Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yidi Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72839 )
Change subject: mb/google/geralt: Calling mt6359p_init() only once in ramstage
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72839/comment/223f69e1_b71778f8
PS1, Line 7: Calling
(Please use imperative mood: Call instead of Calling)
Maybe:
Init MT6359P only once in ramstage
https://review.coreboot.org/c/coreboot/+/72839/comment/3526f8ea_55fbf734
PS1, Line 10: mt6359
mt6359p?
https://review.coreboot.org/c/coreboot/+/72839/comment/59ef73ce_b87af19b
PS1, Line 12:
What user visible problem does multiple initialization cause?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72839
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29498d186ba5665ae20e84985174fc10f8d4accd
Gerrit-Change-Number: 72839
Gerrit-PatchSet: 1
Gerrit-Owner: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 06 Feb 2023 14:22:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment