Attention is currently required from: Arthur Heymans, Julius Werner, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78800?usp=email )
Change subject: arch/arm64/arch_timer: Fix possible overflow in multiplication
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
Patchset:
PS7:
@jwerner, Herobrine's bootblock excceeds allocated size(40K). […]
Can you take a look at the space usage for each symbol (iirc it's already under somewhere in the build folder), and see if there's anything that can be reduced (such as a table)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78800?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I366667de05392913150414f0fa9058725be71c52
Gerrit-Change-Number: 78800
Gerrit-PatchSet: 7
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Thu, 02 Nov 2023 13:01:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment