Change in coreboot[master]: HACK trogdor: Memlayout changed to support QcLib Size increase

[mturney mturney (Code Review)]

Hello [e-mail],

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/36277

to review the following change.

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

HACK trogdor: Memlayout changed to support QcLib Size increase

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/sc7180/include/soc/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/1

diff --git a/src/soc/qualcomm/sc7180/include/soc/memlayout.ld b/src/soc/qualcomm/sc7180/include/soc/memlayout.ld
index ce260aa..6ca3e95 100644
--- a/src/soc/qualcomm/sc7180/include/soc/memlayout.ld
+++ b/src/soc/qualcomm/sc7180/include/soc/memlayout.ld
@@ -59,10 +59,10 @@
    REGION(ddr_training, 0x14850000, 8K, 4K)
    REGION(qclib_serial_log, 0x14852000, 4K, 4K)
    REGION(ddr_information, 0x14853000, 1K, 1K)
-	REGION(dcb, 0x14870000, 16K, 4K)
-	REGION(pmic, 0x14874000, 44K, 4K)
-	REGION(limits_cfg, 0x1487F000, 4K, 4K)
-	REGION(qclib, 0x14880000, 512K, 4K)
+	REGION(dcb, 0x1485b000, 16K, 4K)
+	REGION(pmic, 0x1485f000, 44K, 4K)
+	REGION(limits_cfg, 0x1486a000, 4K, 4K)
+	REGION(qclib, 0x1486b000, 596K, 4K)
    BSRAM_END(0x14900000)

DRAM_START(0x80000000)

[mturney mturney (Code Review)]

Hello Julius Werner, [e-mail], Ravi kumar, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36277

to look at the new patch set (#12).

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

HACK trogdor: Memlayout changed to support QcLib Size increase

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/sc7180/include/soc/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/12

[mturney mturney (Code Review)]

Hello Julius Werner, [e-mail], Ravi kumar, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36277

to look at the new patch set (#16).

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

HACK trogdor: Memlayout changed to support QcLib Size increase

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/common/qclib.c
M src/soc/qualcomm/sc7180/include/soc/memlayout.ld
2 files changed, 4 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/16

[mturney mturney (Code Review)]

Hello Julius Werner, [e-mail], Ravi kumar, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36277

to look at the new patch set (#26).

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

HACK trogdor: Memlayout changed to support QcLib Size increase

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/sc7180/include/soc/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/26

[mturney mturney (Code Review)]

Hello Julius Werner, [e-mail], Ravi kumar, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36277

to look at the new patch set (#28).

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

HACK trogdor: Memlayout changed to support QcLib Size increase

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/sc7180/include/soc/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/28

[mturney mturney (Code Review)]

Hello Julius Werner, [e-mail], Ravi kumar, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36277

to look at the new patch set (#37).

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

HACK trogdor: Memlayout changed to support QcLib Size increase

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/sc7180/include/soc/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/37

[Ravi kumar (Code Review)]

Ravi kumar has uploaded a new patch set (#50) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

HACK trogdor: Memlayout changed to support QcLib Size increase

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/sc7180/include/soc/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/50

[mturney mturney (Code Review)]

Hello Ravi kumar, build bot (Jenkins), Julius Werner, [e-mail],

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36277

to look at the new patch set (#51).

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

HACK trogdor: Memlayout changed to support QcLib Size increase

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/sc7180/include/soc/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/51

[Ravi kumar (Code Review)]

Ravi kumar has uploaded a new patch set (#55) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

HACK trogdor: Memlayout changed to support QcLib Size increase

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/sc7180/include/soc/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/55

[Ravi kumar (Code Review)]

Ravi kumar has uploaded a new patch set (#62) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

HACK trogdor: Memlayout changed to support QcLib Size increase

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/sc7180/include/soc/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/62

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

Patch Set 62:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36277/62//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36277/62//COMMIT_MSG@7 
PS62, Line 7: HACK trogdor: Memlayout changed to support QcLib Size increase
Please make it a statement by adding a verb (in imperative mood):
> Increase memlayout region for grown QcLib

Please also add a body.
> QcLib [version …] is now … big, so reserve enough room by
> allocating 596 K.

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

Patch Set 62:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36277/62//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36277/62//COMMIT_MSG@7 
PS62, Line 7: HACK trogdor: Memlayout changed to support QcLib Size increase
> Please make it a statement by adding a verb (in imperative mood): […]

Just to clarify, anything that starts with "HACK" isn't intended to get submitted, it's just temporary hacks that we like to keep floating on top of the patch train to make things boot while underlying issues are still getting worked on. There's no need to review it.

I don't actually know why this one is still here, either we do need the size increase permanently and this should turn into a normal, cleaned-up CL, or we don't and we can drop this.

[Ravi kumar (Code Review)]

Ravi kumar has uploaded a new patch set (#63) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

HACK trogdor: Memlayout changed to support QcLib Size increase

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/sc7180/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/63

[Ravi kumar (Code Review)]

Ravi kumar has uploaded a new patch set (#64) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

HACK trogdor: Memlayout changed to support QcLib Size increase

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/sc7180/include/soc/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/64

[Ravi kumar (Code Review)]

Ravi kumar has uploaded a new patch set (#66) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: HACK trogdor: Memlayout changed to support QcLib Size increase
......................................................................

HACK trogdor: Memlayout changed to support QcLib Size increase

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/sc7180/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/66

Change in coreboot[master]: trogdor: Memlayout changed to support QcLib Size increase

[Ravi kumar (Code Review)]

Ravi kumar has uploaded a new patch set (#75) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: trogdor: Memlayout changed to support QcLib Size increase
......................................................................

trogdor: Memlayout changed to support QcLib Size increase

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/sc7180/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/75

Change in coreboot[master]: trogdor: Memlayout changed to support QcLib Size increase

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: trogdor: Memlayout changed to support QcLib Size increase
......................................................................

Patch Set 75: Code-Review+2

Change in coreboot[master]: trogdor: Memlayout changed to support QcLib Size increase

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: trogdor: Memlayout changed to support QcLib Size increase
......................................................................

Patch Set 75:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36277/75//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36277/75//COMMIT_MSG@7 
PS75, Line 7: trogdor: Memlayout changed to support QcLib Size increase
google/trogdor: Change Memlayout to support QcLib size increase

https://review.coreboot.org/c/coreboot/+/36277/75//COMMIT_MSG@8 
PS75, Line 8: 
Increase QcLib region from 512 to 596 kB.

Change in coreboot[master]: trogdor: Change Memlayout to increase QcLib region from 512 to 596kB

[Ravi kumar (Code Review)]

Ravi kumar has uploaded a new patch set (#77) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: trogdor: Change Memlayout to increase QcLib region from 512 to 596kB
......................................................................

trogdor: Change Memlayout to increase QcLib region from 512 to 596kB

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
---
M src/soc/qualcomm/sc7180/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36277/77

Change in coreboot[master]: trogdor: Change Memlayout to increase QcLib region from 512 to 596kB

[Ravi Kumar Bokka (Code Review)]

Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: trogdor: Change Memlayout to increase QcLib region from 512 to 596kB
......................................................................

Patch Set 77:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36277/75//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36277/75//COMMIT_MSG@7 
PS75, Line 7: trogdor: Memlayout changed to support QcLib Size increase
> google/trogdor: Change Memlayout to support QcLib size increase

Done

https://review.coreboot.org/c/coreboot/+/36277/75//COMMIT_MSG@8 
PS75, Line 8:
> Increase QcLib region from 512 to 596 kB.

Done

Change in coreboot[master]: trogdor: Change Memlayout to increase QcLib region from 512 to 596kB

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: trogdor: Change Memlayout to increase QcLib region from 512 to 596kB
......................................................................

Patch Set 79: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/36277/62//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36277/62//COMMIT_MSG@7 
PS62, Line 7: HACK trogdor: Memlayout changed to support QcLib Size increase
> Just to clarify, anything that starts with "HACK" isn't intended to get submitted, it's just tempora […]

Done

Change in coreboot[master]: trogdor: Change Memlayout to increase QcLib region from 512 to 596kB

[Julius Werner (Code Review)]

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: trogdor: Change Memlayout to increase QcLib region from 512 to 596kB
......................................................................

trogdor: Change Memlayout to increase QcLib region from 512 to 596kB

Change-Id: I49008ea9bc6254c745352b2e8ee965ddc2e8e5e4
Signed-off-by: Ashwin Kumar 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36277
Tested-by: build bot (Jenkins) 
Reviewed-by: Julius Werner 
---
M src/soc/qualcomm/sc7180/memlayout.ld
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Julius Werner: Looks good to me, approved

diff --git a/src/soc/qualcomm/sc7180/memlayout.ld b/src/soc/qualcomm/sc7180/memlayout.ld
index 2a0cd8a..94300e8 100644
--- a/src/soc/qualcomm/sc7180/memlayout.ld
+++ b/src/soc/qualcomm/sc7180/memlayout.ld
@@ -40,10 +40,10 @@
    REGION(qclib_serial_log, 0x14852000, 4K, 4K)
    REGION(ddr_information, 0x14853000, 1K, 1K)
    FMAP_CACHE(0x14853400, 2K)
-	REGION(dcb, 0x14870000, 16K, 4K)
-	REGION(pmic, 0x14874000, 44K, 4K)
-	REGION(limits_cfg, 0x1487F000, 4K, 4K)
-	REGION(qclib, 0x14880000, 512K, 4K)
+	REGION(dcb, 0x1485b000, 16K, 4K)
+	REGION(pmic, 0x1485f000, 44K, 4K)
+	REGION(limits_cfg, 0x1486a000, 4K, 4K)
+	REGION(qclib, 0x1486b000, 596K, 4K)
    BSRAM_END(0x14900000)

DRAM_START(0x80000000)

Change in coreboot[master]: trogdor: Change Memlayout to increase QcLib region from 512 to 596kB

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36277 )

Change subject: trogdor: Change Memlayout to increase QcLib region from 512 to 596kB
......................................................................

Patch Set 83:

Automatic boot test returned (PASS/FAIL/TOTAL): 7/1/8
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/18547
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18546
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/18545
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18544
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/18543
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/18550
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/18549
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18548

Please note: This test is under development and might not be accurate at all!