Change in coreboot[master]: device/i2c_bus: Add detect function pointer in i2c_bus_ops - coreboot-gerrit

1 Apr 2022


      Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Julius Werner, Karthik Ramasubramanian.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63209 )
Change subject: device/i2c_bus: Add detect function pointer in i2c_bus_ops
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
...
Do we really need to add a new method for this? Sounds like all you're trying to do is a zero-byte w […]
regardless if a new function is used, the new pointer in the ops struct is still needed, no?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63209
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8ddfb187eabec966c253b6cc8526491c99151fc
Gerrit-Change-Number: 63209
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Fri, 01 Apr 2022 02:09:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment