Ian Feng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40774 )
Change subject: mb/google/dedede: Enable USB port for camera support ......................................................................
mb/google/dedede: Enable USB port for camera support
Support USB Chicony user facing camera.
BUG=b:155109736 BRANCH=None TEST=Build and Boot waddledoo board and able to capture image using user facing camera.
Signed-off-by: Ian Feng ian_feng@compal.corp-partner.google.com Change-Id: I7580a58086977e239dca49c1def4f03583831662 --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/40774/1
diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index cfe221f..c7cf5db 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -32,7 +32,7 @@ register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0 register "usb2_ports[3]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A1 register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # Discrete Bluetooth - register "usb2_ports[5]" = "USB2_PORT_EMPTY" # Not Used + register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # Camera register "usb2_ports[6]" = "USB2_PORT_EMPTY" # Not Used register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # Integrated Bluetooth
@@ -212,6 +212,11 @@ device usb 2.4 on end end chip drivers/usb/acpi + register "desc" = ""Camera"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.5 on end + end + chip drivers/usb/acpi register "desc" = ""Integrated Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H19)"
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40774 )
Change subject: mb/google/dedede: Enable USB port for camera support ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40774/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40774/1//COMMIT_MSG@9 PS1, Line 9: Support USB Chicony user facing camera. Are all SKUs of waddledoo going to use USB UFC?
https://review.coreboot.org/c/coreboot/+/40774/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40774/1/src/mainboard/google/dedede... PS1, Line 215: register "desc" = ""Camera"" Probably move to overridetree.cb for waddledoo?
Hello build bot (Jenkins), Furquan Shaikh, Marco Chen, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40774
to look at the new patch set (#2).
Change subject: mb/google/dedede: Enable USB port for camera support ......................................................................
mb/google/dedede: Enable USB port for camera support
Support USB Chicony user facing camera.
BUG=b:155109736 BRANCH=None TEST=Build and Boot waddledoo board and able to capture image using user facing camera.
Signed-off-by: Ian Feng ian_feng@compal.corp-partner.google.com Change-Id: I7580a58086977e239dca49c1def4f03583831662 --- M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/40774/2
Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40774 )
Change subject: mb/google/dedede: Enable USB port for camera support ......................................................................
Patch Set 2:
(2 comments)
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40774/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40774/1//COMMIT_MSG@9 PS1, Line 9: Support USB Chicony user facing camera.
Are all SKUs of waddledoo going to use USB UFC?
Yes
https://review.coreboot.org/c/coreboot/+/40774/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40774/1/src/mainboard/google/dedede... PS1, Line 215: register "desc" = ""Camera""
Probably move to overridetree. […]
Done
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40774 )
Change subject: mb/google/dedede: Enable USB port for camera support ......................................................................
Patch Set 2: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40774 )
Change subject: mb/google/dedede: Enable USB port for camera support ......................................................................
Patch Set 2: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40774 )
Change subject: mb/google/dedede: Enable USB port for camera support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40774/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40774/1//COMMIT_MSG@9 PS1, Line 9: Support USB Chicony user facing camera.
Yes
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40774 )
Change subject: mb/google/dedede: Enable USB port for camera support ......................................................................
mb/google/dedede: Enable USB port for camera support
Support USB Chicony user facing camera.
BUG=b:155109736 BRANCH=None TEST=Build and Boot waddledoo board and able to capture image using user facing camera.
Signed-off-by: Ian Feng ian_feng@compal.corp-partner.google.com Change-Id: I7580a58086977e239dca49c1def4f03583831662 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40774 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb index 920c179..b9346af 100644 --- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb @@ -1,5 +1,8 @@ chip soc/intel/jasperlake
+ # USB Port Configuration + register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # Camera + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | @@ -45,6 +48,17 @@ }, }" device domain 0 on + device pci 14.0 on + chip drivers/usb/acpi + device usb 0.0 on + chip drivers/usb/acpi + register "desc" = ""Camera"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.5 on end + end + end + end + end # USB xHCI device pci 15.0 on chip drivers/i2c/generic register "hid" = ""ELAN0000""
-
Ian Feng (Code Review) -
Justin TerAvest (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)