Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48780 )
Change subject: soc/intel/{icl,tgl,adl,ehl,jsl}: move UART pad config to boards
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 1:
(1 comment)
Patch Set 1:
How do you know which boards have multiple UARTs? Removing the common code will make it impossible to use them when changing the UART_FOR_CONSOLE kconfig.
That's not true; the boards just have to configure the pads for all UARTs correctly
How do you prove that this change doesn't introduce regressions without having access to all board schematics?
That's why we have a review system, right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48780
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5150110dd13e9da981a0c8614ee642037e209ca4
Gerrit-Change-Number: 48780
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Chen
Tim-Chen@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 21 Dec 2020 20:06:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment