Attention is currently required from: Bora Guvendik, Felix Singer, Lijian Zhao, Shaunak Saha, Nico Huber, Martin Roth, Michael Niewöhner, Tim Wawrzynczak, Aaron Durbin, Patrick Rudolph.
Vaibhav Shankar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56662 )
Change subject: Revert "src/soc/intel/cannonlake: Update C-state latency control limits"
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56662/comment/8313eb9c_9943c8d1
PS1, Line 14:
How was this tested? Does S0ix still work?
S0ix is enabled by default on all recent chromeOs platfroms. You can check the S0ix entry and exit counts from sysfs- PMC core driver
Patchset:
PS1:
So, the previous values were for Cannon Lake, while the previous ones are Coffee Lake. […]
The cannon lake support was dropped. If you are using Coffe lake, then you might have to use board- skylake values becaue its based out of 14nm.
reference to previous IRTL values(14nm)-
https://github.com/coreboot/coreboot/blob/master/src/soc/intel/skylake/cpu.c
Why are we modfying cannonlake values ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea56c6a29ca4b34c9852393fed2e3be4de128ec6
Gerrit-Change-Number: 56662
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Vaibhav Shankar
vaibhav.shankar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Attention: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 02 Aug 2021 21:06:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Comment-In-Reply-To: Vaibhav Shankar
vaibhav.shankar@intel.com
Gerrit-MessageType: comment