Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42431 )
Change subject: mb/asrock/b85m_pro4: Disable PS/2 keyboard wakeup ......................................................................
mb/asrock/b85m_pro4: Disable PS/2 keyboard wakeup
This results in a wake from S5 as well. Since the PS/2 keyboard now works, this behavior is annoying and, therefore, undesired.
Change-Id: I180f17c87df23f2a1bbd5c968c64a4b2bc7d9978 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b85m_pro4/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/42431/1
diff --git a/src/mainboard/asrock/b85m_pro4/devicetree.cb b/src/mainboard/asrock/b85m_pro4/devicetree.cb index a5c275d..a044d0a 100644 --- a/src/mainboard/asrock/b85m_pro4/devicetree.cb +++ b/src/mainboard/asrock/b85m_pro4/devicetree.cb @@ -96,7 +96,6 @@ irq 0xe0 = 0xff # + GPIO7 direction end device pnp 2e.a on # ACPI - irq 0xe0 = 0x41 # + Enable KBC wakeup irq 0xe4 = 0x10 # + Power RAM in S3 irq 0xf0 = 0x20 end
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42431 )
Change subject: mb/asrock/b85m_pro4: Disable PS/2 keyboard wakeup ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42431/1/src/mainboard/asrock/b85m_p... File src/mainboard/asrock/b85m_pro4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42431/1/src/mainboard/asrock/b85m_p... PS1, Line 99: irq 0xe0 = 0x41 # + Enable KBC wakeup Leave it as a comment for people wanting this feature?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42431 )
Change subject: mb/asrock/b85m_pro4: Disable PS/2 keyboard wakeup ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42431/1/src/mainboard/asrock/b85m_p... File src/mainboard/asrock/b85m_pro4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42431/1/src/mainboard/asrock/b85m_p... PS1, Line 99: irq 0xe0 = 0x41 # + Enable KBC wakeup
Leave it as a comment for people wanting this feature?
What for? There's a precious datasheet that explains it much better than a comment:
https://media.digikey.com/pdf/Data%20Sheets/Nuvoton%20PDFs/NCT6776F,D.pdf
Plus, this would be better located at the Super I/O level as a Kconfig option
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42431 )
Change subject: mb/asrock/b85m_pro4: Disable PS/2 keyboard wakeup ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42431/1/src/mainboard/asrock/b85m_p... File src/mainboard/asrock/b85m_pro4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42431/1/src/mainboard/asrock/b85m_p... PS1, Line 99: irq 0xe0 = 0x41 # + Enable KBC wakeup
What for? There's a precious datasheet that explains it much better than a comment: […]
Ack
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42431 )
Change subject: mb/asrock/b85m_pro4: Disable PS/2 keyboard wakeup ......................................................................
Patch Set 9: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42431 )
Change subject: mb/asrock/b85m_pro4: Disable PS/2 keyboard wakeup ......................................................................
mb/asrock/b85m_pro4: Disable PS/2 keyboard wakeup
This results in a wake from S5 as well. Since the PS/2 keyboard now works, this behavior is annoying and, therefore, undesired.
Change-Id: I180f17c87df23f2a1bbd5c968c64a4b2bc7d9978 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42431 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asrock/b85m_pro4/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/mainboard/asrock/b85m_pro4/devicetree.cb b/src/mainboard/asrock/b85m_pro4/devicetree.cb index a5c275d..a044d0a 100644 --- a/src/mainboard/asrock/b85m_pro4/devicetree.cb +++ b/src/mainboard/asrock/b85m_pro4/devicetree.cb @@ -96,7 +96,6 @@ irq 0xe0 = 0xff # + GPIO7 direction end device pnp 2e.a on # ACPI - irq 0xe0 = 0x41 # + Enable KBC wakeup irq 0xe4 = 0x10 # + Power RAM in S3 irq 0xf0 = 0x20 end
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Paul Menzel (Code Review)