Attention is currently required from: Martin Roth, Karthik Ramasubramanian, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56818 )
Change subject: soc/amd/common/block/spi: Don't update spi speed if EFS is changed
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/spi/fch_spi.c:
https://review.coreboot.org/c/coreboot/+/56818/comment/d938615a_fdf92883
PS2, Line 84: if (CONFIG(EM100))
: fch_spi_config_em100_modes();
: else
: fch_spi_config_mb_modes();
This should be completely dropped and instead coreboot should rely on using EFS fields to determine the speed that must be configured. This is redundant once EFS is used for the configuration.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56818
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278768e361499919666d07e1dd92d83c2390035e
Gerrit-Change-Number: 56818
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 06 Aug 2021 18:36:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment