[L] Change in coreboot[main]: soc/mediatek/mt8196: Add DDP driver

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Nancy Lin, Paul Menzel, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85950?usp=email )

Change subject: soc/mediatek/mt8196: Add DDP driver
......................................................................

Patch Set 4:

(9 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85950/comment/c69db55f_aceffb17?usp... :
PS4, Line 9: controller
IIUC DDP means "display datapath". Is that correct?

File src/soc/mediatek/common/display.c:

https://review.coreboot.org/c/coreboot/+/85950/comment/bb8165d2_556d78ec?usp... :
PS2, Line 46: __weak int mtk_edp_enable(void)
> mt8195/mt8188 should have the same issue. […]

Nancy, can I say that, `dptx_video_enable(true)` needs to be called after `mtk_ddp_mode_set` (I assume that's what you meant by "display pipe initialization")?

File src/soc/mediatek/mt8196/ddp.c:

https://review.coreboot.org/c/coreboot/+/85950/comment/82e9bea1_b7612b2a?usp... :
PS3, Line 30: 	default:
Print an error log here.

https://review.coreboot.org/c/coreboot/+/85950/comment/2a43b008_d3595ecc?usp... :
PS3, Line 212: blender_config(i, width, height, blender_type[i]);
             : 		blender_start(i);
```
const struct blender *blender = &blenders[i];
blender_config(blender, width, height, blender_type[i]);
blender_start(blender);
```

File src/soc/mediatek/mt8196/ddp.c:

https://review.coreboot.org/c/coreboot/+/85950/comment/2fb44653_31519745?usp... :
PS4, Line 268: clrsetbits32
setbits32

https://review.coreboot.org/c/coreboot/+/85950/comment/4aea9f9b_fc1d384c?usp... :
PS4, Line 269: clrsetbits32
setbits32

File src/soc/mediatek/mt8196/include/soc/ddp.h:

https://review.coreboot.org/c/coreboot/+/85950/comment/92de02f6_fa875d75?usp... :
PS3, Line 190: };
one blank line below

https://review.coreboot.org/c/coreboot/+/85950/comment/334af2b5_a8ca94e4?usp... :
PS3, Line 227: };
blank line

https://review.coreboot.org/c/coreboot/+/85950/comment/a7f77e07_f6c04a24?usp... :
PS3, Line 254: };
blank line