Change in coreboot[master]: mainboard/google/puff: Cleanup pcie 15.3 ep in dt

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38099 ) Change subject: mainboard/google/puff: Cleanup pcie 15.3 ep in dt ...................................................................... mainboard/google/puff: Cleanup pcie 15.3 ep in dt Clean up devicetree as nothing special is needed here. BUG=b:142769041 BRANCH=none TEST=builds Change-Id: I0790631233fdcaa6a785d2cb41e79b8f2f469d44 Signed-off-by: Edward O'Callaghan <quasisec@google.com> --- M src/mainboard/google/hatch/variants/puff/overridetree.cb 1 file changed, 1 insertion(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/38099/1 diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb index 4385e98..e3ccc61 100644 --- a/src/mainboard/google/hatch/variants/puff/overridetree.cb +++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb @@ -157,13 +157,7 @@ end # I2C #0 device pci 15.1 off end # I2C #1 device pci 15.2 on end # I2C #2, PCON PS175. - device pci 15.3 on -# chip drivers/i2c/generic -# register "name" = ""RTD21"" -# register "desc" = ""Realtek RTD2142"" -# device i2c 4a on end -# end - end # I2C #3 + device pci 15.3 on end # I2C #3, Realtek RTD2142. device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" -- To view, visit https://review.coreboot.org/c/coreboot/+/38099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0790631233fdcaa6a785d2cb41e79b8f2f469d44 Gerrit-Change-Number: 38099 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-MessageType: newchange

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38099 ) Change subject: mainboard/google/puff: Cleanup pcie 15.3 ep in dt ...................................................................... Patch Set 1: Code-Review+2 Looks reasonable. We can always re-enable if needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/38099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0790631233fdcaa6a785d2cb41e79b8f2f469d44 Gerrit-Change-Number: 38099 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Kangheui Won <khwon@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 02 Jan 2020 08:14:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38099 ) Change subject: mainboard/google/puff: Cleanup pcie 15.3 ep in dt ...................................................................... Patch Set 1:
Patch Set 1: Code-Review+2
Looks reasonable. We can always re-enable if needed.
It isn't disabling anything here, just deleting dead commented code. -- To view, visit https://review.coreboot.org/c/coreboot/+/38099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0790631233fdcaa6a785d2cb41e79b8f2f469d44 Gerrit-Change-Number: 38099 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Kangheui Won <khwon@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 02 Jan 2020 09:17:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38099 ) Change subject: mainboard/google/puff: Cleanup pcie 15.3 ep in dt ...................................................................... Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review+2
Looks reasonable. We can always re-enable if needed.
It isn't disabling anything here, just deleting dead commented code.
Oops. Even better. -- To view, visit https://review.coreboot.org/c/coreboot/+/38099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0790631233fdcaa6a785d2cb41e79b8f2f469d44 Gerrit-Change-Number: 38099 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Kangheui Won <khwon@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 02 Jan 2020 11:14:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38099 ) Change subject: mainboard/google/puff: Cleanup pcie 15.3 ep in dt ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/38099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0790631233fdcaa6a785d2cb41e79b8f2f469d44 Gerrit-Change-Number: 38099 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Kangheui Won <khwon@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 02 Jan 2020 12:26:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38099 ) Change subject: mainboard/google/puff: Cleanup pcie 15.3 ep in dt ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/38099/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/38099/1//COMMIT_MSG@7 PS1, Line 7: Cleanup Clean up -- To view, visit https://review.coreboot.org/c/coreboot/+/38099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0790631233fdcaa6a785d2cb41e79b8f2f469d44 Gerrit-Change-Number: 38099 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Kangheui Won <khwon@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Thu, 02 Jan 2020 13:02:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Hello Kangheui Won, build bot (Jenkins), Daniel Kurtz, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/38099 to look at the new patch set (#2). Change subject: mainboard/google/puff: Clean up pcie 15.3 ep in dt ...................................................................... mainboard/google/puff: Clean up pcie 15.3 ep in dt Clean up devicetree as nothing special is needed here. BUG=b:142769041 BRANCH=none TEST=builds Change-Id: I0790631233fdcaa6a785d2cb41e79b8f2f469d44 Signed-off-by: Edward O'Callaghan <quasisec@google.com> --- M src/mainboard/google/hatch/variants/puff/overridetree.cb 1 file changed, 1 insertion(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/38099/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/38099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0790631233fdcaa6a785d2cb41e79b8f2f469d44 Gerrit-Change-Number: 38099 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Kangheui Won <khwon@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38099 ) Change subject: mainboard/google/puff: Clean up pcie 15.3 ep in dt ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/38099/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/38099/1//COMMIT_MSG@7 PS1, Line 7: Cleanup
Clean up Done
-- To view, visit https://review.coreboot.org/c/coreboot/+/38099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0790631233fdcaa6a785d2cb41e79b8f2f469d44 Gerrit-Change-Number: 38099 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Kangheui Won <khwon@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Fri, 03 Jan 2020 00:08:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: comment

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38099 ) Change subject: mainboard/google/puff: Clean up pcie 15.3 ep in dt ...................................................................... mainboard/google/puff: Clean up pcie 15.3 ep in dt Clean up devicetree as nothing special is needed here. BUG=b:142769041 BRANCH=none TEST=builds Change-Id: I0790631233fdcaa6a785d2cb41e79b8f2f469d44 Signed-off-by: Edward O'Callaghan <quasisec@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/38099 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Daniel Kurtz <djkurtz@google.com> Reviewed-by: Kangheui Won <khwon@chromium.org> --- M src/mainboard/google/hatch/variants/puff/overridetree.cb 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: build bot (Jenkins): Verified Daniel Kurtz: Looks good to me, approved Kangheui Won: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb index 4385e98..e3ccc61 100644 --- a/src/mainboard/google/hatch/variants/puff/overridetree.cb +++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb @@ -157,13 +157,7 @@ end # I2C #0 device pci 15.1 off end # I2C #1 device pci 15.2 on end # I2C #2, PCON PS175. - device pci 15.3 on -# chip drivers/i2c/generic -# register "name" = ""RTD21"" -# register "desc" = ""Realtek RTD2142"" -# device i2c 4a on end -# end - end # I2C #3 + device pci 15.3 on end # I2C #3, Realtek RTD2142. device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682"" -- To view, visit https://review.coreboot.org/c/coreboot/+/38099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0790631233fdcaa6a785d2cb41e79b8f2f469d44 Gerrit-Change-Number: 38099 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Kangheui Won <khwon@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: merged
participants (4)
-
Daniel Kurtz (Code Review)
-
Edward O'Callaghan (Code Review)
-
Kangheui Won (Code Review)
-
Paul Menzel (Code Review)