Attention is currently required from: Tarun Tuli, Dtrain Hsu, Ian Feng.
Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71706 )
Change subject: mb/google/brya/var/omnigul: Update GPIO settings ......................................................................
Patch Set 10:
(12 comments)
File src/mainboard/google/brya/variants/omnigul/gpio.c:
https://review.coreboot.org/c/coreboot/+/71706/comment/6aa601cf_eba2fa71 PS9, Line 92: PAD_CFG_GPI_APIC_LOCK(GPP_D5, NONE, LEVEL, NONE, LOCK_CONFIG),
Does it use for interrupt? If no, it might be PAD_CFG_GPI_LOCK.
Done
https://review.coreboot.org/c/coreboot/+/71706/comment/8618abca_7b0a91ed PS9, Line 96: PAD_CFG_GPI_APIC
Does it use for interrupt? If no, it might be PAD_CFG_GPI.
Done
https://review.coreboot.org/c/coreboot/+/71706/comment/8aa65d1e_2d4b65a4 PS9, Line 104: PAD_CFG_GPI_APIC
Same as GPP_D8.
Done
https://review.coreboot.org/c/coreboot/+/71706/comment/36dd5350_873494d8 PS9, Line 108: PAD_CFG_GPI_APIC
Same as GPP_D8.
Done
https://review.coreboot.org/c/coreboot/+/71706/comment/f57be8b8_9043d3d0 PS9, Line 110: PAD_CFG_GPI_APIC
Same as GPP_D8.
Done
https://review.coreboot.org/c/coreboot/+/71706/comment/0b593022_7a8bc41a PS9, Line 112: PAD_CFG_GPI_APIC
Same as GPP_D8.
Done
https://review.coreboot.org/c/coreboot/+/71706/comment/949e1459_b4af5181 PS9, Line 122: PAD_CFG_GPI_APIC
Same as GPP_D8.
Done
https://review.coreboot.org/c/coreboot/+/71706/comment/2e772b42_c2551ea4 PS9, Line 128: PAD_CFG_GPI_APIC
Same as GPP_D8.
Done
https://review.coreboot.org/c/coreboot/+/71706/comment/4049a50b_197e61de PS9, Line 132: PAD_CFG_GPI_APIC_LOCK(GPP_E10, NONE, LEVEL, NONE, LOCK_CONFIG),
Same as GPP_D5.
Done
https://review.coreboot.org/c/coreboot/+/71706/comment/1165b37b_02125c20 PS9, Line 141: PAD_CFG_GPI_APIC_LOCK(GPP_E17, NONE, LEVEL, NONE, LOCK_CONFIG),
Same as GPP_D5.
Done
https://review.coreboot.org/c/coreboot/+/71706/comment/da6149e7_57e5b4a5 PS9, Line 145: PAD_CFG_GPI_APIC
Same as GPP_D8.
Done
https://review.coreboot.org/c/coreboot/+/71706/comment/7003598b_a0ff564e PS9, Line 180: PAD_CFG_GPI_APIC_LOCK
Same as GPP_D5.
Done
-
Jamie Chen (Code Review)