Change in coreboot[master]: cbfs: Fix attribute tag printing in cbfs_find_attr()

[Julius Werner (Code Review)]

Hello Furquan Shaikh, Aaron Durbin,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/48836

to review the following change.

Change subject: cbfs: Fix attribute tag printing in cbfs_find_attr()
......................................................................

cbfs: Fix attribute tag printing in cbfs_find_attr()

Attribute tags are defined as hexadecimal constants, not decimal, so it
makes more sense to print them like that in error messages as well.

Signed-off-by: Julius Werner 
Change-Id: I3a5a6a8c9b8d24e57633595fc47221a483d8593a
---
M src/commonlib/bsd/cbfs_private.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/48836/1

diff --git a/src/commonlib/bsd/cbfs_private.c b/src/commonlib/bsd/cbfs_private.c
index 527860d..91f81e0 100644
--- a/src/commonlib/bsd/cbfs_private.c
+++ b/src/commonlib/bsd/cbfs_private.c
@@ -173,13 +173,13 @@
    	const uint32_t len = be32toh(attr->len);

if (offset + len > end) {
-			ERROR("Attribute %s[%u] overflows end of metadata\n",
+			ERROR("Attribute %s[%x] overflows end of metadata\n",
    		      mdata->h.filename, tag);
    		return NULL;
    	}
    	if (tag == attr_tag) {
    		if (size_check && len != size_check) {
-				ERROR("Attribute %s[%u] size mismatch: %u != %zu\n",
+				ERROR("Attribute %s[%x] size mismatch: %u != %zu\n",
    			      mdata->h.filename, tag, len, size_check);
    			return NULL;
    		}

[Julius Werner (Code Review)]

Attention is currently required from: Julius Werner.
Julius Werner has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/48836 )

Change subject: cbfs: Fix attribute tag printing in cbfs_find_attr()
......................................................................

Removed Verified-1 by build bot (Jenkins)

[Angel Pons (Code Review)]

Attention is currently required from: Julius Werner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48836 )

Change subject: cbfs: Fix attribute tag printing in cbfs_find_attr()
......................................................................

Patch Set 7: Code-Review+2

[Aaron Durbin (Code Review)]

Attention is currently required from: Julius Werner.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48836 )

Change subject: cbfs: Fix attribute tag printing in cbfs_find_attr()
......................................................................

Patch Set 7: Code-Review+2

[Julius Werner (Code Review)]

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48836 )

Change subject: cbfs: Fix attribute tag printing in cbfs_find_attr()
......................................................................

cbfs: Fix attribute tag printing in cbfs_find_attr()

Attribute tags are defined as hexadecimal constants, not decimal, so it
makes more sense to print them like that in error messages as well.

Signed-off-by: Julius Werner 
Change-Id: I3a5a6a8c9b8d24e57633595fc47221a483d8593a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48836
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Aaron Durbin 
---
M src/commonlib/bsd/cbfs_private.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/commonlib/bsd/cbfs_private.c b/src/commonlib/bsd/cbfs_private.c
index 527860d..91f81e0 100644
--- a/src/commonlib/bsd/cbfs_private.c
+++ b/src/commonlib/bsd/cbfs_private.c
@@ -173,13 +173,13 @@
    	const uint32_t len = be32toh(attr->len);

if (offset + len > end) {
-			ERROR("Attribute %s[%u] overflows end of metadata\n",
+			ERROR("Attribute %s[%x] overflows end of metadata\n",
    		      mdata->h.filename, tag);
    		return NULL;
    	}
    	if (tag == attr_tag) {
    		if (size_check && len != size_check) {
-				ERROR("Attribute %s[%u] size mismatch: %u != %zu\n",
+				ERROR("Attribute %s[%x] size mismatch: %u != %zu\n",
    			      mdata->h.filename, tag, len, size_check);
    			return NULL;
    		}