Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Arthur Heymans.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72806 )
Change subject: nb/intel/haswell/pcie.c: Make UBSAN shut up
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72806/comment/7198dfc2_c65147c9
PS1, Line 7: nb/intel/haswell/pcie.c: Make UBSAN shut up
Maybe:
nb/intel/haswell/pcie: Use unsigned integers to fix shift OOB
https://review.coreboot.org/c/coreboot/+/72806/comment/09c21840_b9506768
PS1, Line 17:
It’d be great if you added:
Link: https://ticket.coreboot.org/issues/449
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72806
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf8710a5ae4e05d9f41f40f9e3617e155027800c
Gerrit-Change-Number: 72806
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 07 Feb 2023 14:53:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment