Attention is currently required from: Angel Pons, Felix Singer, Jan Philipp Groß, Máté Kukri, Paul Menzel.
Nicholas Chin has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82913?usp=email )
Change subject: mb/asrock: Add Fatal1ty Z87 Professional (Haswell)
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/asrock/fatal1ty_z87_professional/Kconfig:
https://review.coreboot.org/c/coreboot/+/82913/comment/7ed314f8_c564c03c?usp... :
PS7, Line 24: int
Aside, should we remove it from existing boards?
Sure. It has been done before for the other configs and I think the USBDEBUG_HCD_INDEX is often the only config left with a type for a lot of board Kconfigs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82913?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iae0b73d8e81be90ec3a2d5463df3ed170f603266
Gerrit-Change-Number: 82913
Gerrit-PatchSet: 7
Gerrit-Owner: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Máté Kukri
kukri.mate@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 08 Jun 2024 16:37:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com