Change in coreboot[master]: DO-NOT-SUBMIT: Asurada ToT - Coreboot - coreboot-gerrit

List overview All Threads
Download

newer

Change in coreboot[master]: DO-NOT-SUBMIT: Asurada ToT - Coreboot

older

Change in coreboot[master]:...

Yidi Lin (Code Review)

14 Oct 2020 14 Oct '20

1:26 p.m.

Hello CK HU,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to review the following change.

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 --- M README.md 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/1

diff --git a/README.md b/README.md index 14879c1..d2b1bc8 100644 --- a/README.md +++ b/README.md @@ -102,3 +102,4 @@ Please check the individual source files for details.

This makes the resulting coreboot images licensed under the GPL, version 2. +

Attachments:

attachment.htm (text/html — 2.1 KB)

Show replies by date

Yidi Lin (Code Review)

15 Oct 15 Oct

1:44 p.m.

Hello Hung-Te Lin, build bot (Jenkins), Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#2).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

1. Move CL:44705 CL:46403 CL:46404 to the head of the chain. 2. Pick changes: https://chromium-review.googlesource.com/c/2473983 - Keep CONN MCU in reset state 3. Update changes: CL:45398 (https://chromium-review.googlesource.com/c/2235267) soc/mediatek/mt8192: add pmif driver CL:45399 (https://chromium-review.googlesource.com/c/2235268) soc/mediatek/mt8192: add pmic MT6359P driver 4. Exclude changes: CL:46396 (https://chromium-review.googlesource.com/c/2345832) soc/mediatek/mt8192: add pmif driver support for romstage CL:46397 (https://chromium-review.googlesource.com/c/2345833) soc/mediatek/mt8192: add 6359p driver support for romstage

Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 --- M README.md 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/2

Yidi Lin (Code Review)

2:04 p.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 2:

Yidi Lin (Code Review)

3:04 p.m.

Hello Hung-Te Lin, build bot (Jenkins), Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#3).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

Update changes: CL:44569 soc/mediatek/mt8192: Do dram fast calibration CL:44568 mb/google/asurada: Init dram in romstage

Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 --- M 3rdparty/blobs M README.md 2 files changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/3

Yidi Lin (Code Review)

3:10 p.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 3:

Update changes: CL:44569 soc/mediatek/mt8192: Do dram fast calibration CL:44568 mb/google/asurada: Init dram in romstage CL:46385 mb/google/asurada: enable SPI devices

Yidi Lin (Code Review)

16 Oct 16 Oct

9:02 a.m.

Hello Hung-Te Lin, build bot (Jenkins), Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#4).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

Move following changes to the head of the chain: CB:46387 soc/mediatek/mt8192: disable_l2c_sram in ramstage CB:46394 mb/google/asurada: change EC SPI to 3M CB:46386 mb/google/asurada: Add Chrome OS GPIOs CB:46385 mb/google/asurada: enable SPI devices CB:46382 soc/mediatek/mt8192: enable CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE

Merge CB:46383 into CB:46382

Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 --- M 3rdparty/blobs M README.md 2 files changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/4

Yidi Lin (Code Review)

20 Oct 20 Oct

2:42 p.m.

Hello Hung-Te Lin, build bot (Jenkins), Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#6).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

Pick: CB:46585 soc/mediatek/mt8192: add dram log prefix

Update: CB:46386 mb/google/asurada: Add Chrome OS GPIOs CB:46393 soc/mediatek/mt8192: Add dpm loader CB:44699 soc/mediatek/mt8192: fix impedance tracking channel number CB:46405 soc/mediatek/mt8192: Add board-specific regulator APIs

Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 --- M 3rdparty/blobs M README.md 2 files changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/6

Yidi Lin (Code Review)

22 Oct 22 Oct

8:57 a.m.

Hello Hung-Te Lin, build bot (Jenkins), Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#7).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

Pick: CB:46616 soc/mediatek/mt8192: update descriptions for dram config

Update: CB:46585 soc/mediatek/mt8192: add dram log prefix CB:46394 mb/google/asurada: change EC SPI to 3M CB:46406 mb/google/asurada: Implement board-specific regulator controls.

Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 --- M 3rdparty/blobs M README.md 2 files changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/7

pan gao (Code Review)

12:54 p.m.

pan gao has uploaded a new patch set (#10) to the change originally created by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

Pick: CB:46616 soc/mediatek/mt8192: update descriptions for dram config

Update: CB:46585 soc/mediatek/mt8192: add dram log prefix CB:46394 mb/google/asurada: change EC SPI to 3M CB:46406 mb/google/asurada: Implement board-specific regulator controls.

Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 --- M 3rdparty/blobs M README.md 2 files changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/10

Yidi Lin (Code Review)

23 Oct 23 Oct

9:24 a.m.

Hello Hung-Te Lin, build bot (Jenkins), pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#11).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

Update: CB:46392 soc/mediatek/mt8192: Load MCUPM firmware and boot up MCUPM

Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 --- M README.md 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/11

Yidi Lin (Code Review)

9:29 a.m.

Hello Hung-Te Lin, build bot (Jenkins), pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#12).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

Update: CB:46392 soc/mediatek/mt8192: Load MCUPM firmware and boot up MCUPM CB:46409 soc/mediatek/mt8192: eint: unmask eint event mask register

Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 --- M README.md 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/12

Yidi Lin (Code Review)

1:55 p.m.

Hello Hung-Te Lin, build bot (Jenkins), pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#13).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 --- M README.md 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/13

Yidi Lin (Code Review)

26 Oct 26 Oct

3:31 p.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 14:

Update: CB:46685 mb/google/asurada: Configure pinctrl for SD and MMC CB:46406 mb/google/asurada: Implement board-specific regulator controls CB:46686 ec/google/chromeec: Add more wrappers for regulator control CB:46687 mb/google/asurada: Implement enable_requlator and regulator_is_enabled

Move CB:46685 CB:46388 to the head of the chain

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 14 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 26 Oct 2020 14:31:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

27 Oct 27 Oct

1:34 p.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 15:

Update: CB:44570 soc/mediatek/mt8192: Do dram full calibration CB:46406 mb/google/asurada: Implement board-specific regulator controls CB:46686 ec/google/chromeec: Add more wrappers for regulator control CB:46687 mb/google/asurada: Implement enable_requlator and regulator_is_enabled Add: CB:46843 HACK: dramc_pi_api.h: revert the order of the enum constants

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 15 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 27 Oct 2020 12:34:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

28 Oct 28 Oct

1:38 p.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 18:

Update: CB:44570 soc/mediatek/mt8192: Do dram full calibration CB:46406 mb/google/asurada: Implement board-specific regulator controls CB:46687 mb/google/asurada: Implement enable_requlator and regulator_is_enabled CB:46389 mediatek/mt8192: add spmfw loader - update hex array for suspend issue CB:44699 soc/mediatek/mt8192: Add dram control register define and bits define - Change DQS_8PH_* constants order Pick: CB:46877 soc/mediatek/mt8192: add rtc MT6359P driver - Fixup patch (?) CB:46878 soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver CB:46883 soc/mediatek/mt8192: add rtc MT6359P lpd_init

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 18 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 28 Oct 2020 12:38:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

29 Oct 29 Oct

1:05 p.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 20:

Update: CB:46401 soc/mediatek/mt8192: Reserve 44K SRAM for MPUPM working buffer

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 20 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 29 Oct 2020 12:05:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

30 Oct 30 Oct

4:42 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 22:

Update: CB:46390 soc/mediatek/mt8192: Add auxadc driver CB:46391 mb/google/asurada: Get RAM code from ADC 3 - auxadc_get_voltage -> auxadc_get_voltage_uv CB:46401 soc/mediatek/mt8192: Reserve 44K SRAM for MPUPM working buffer CB:46402 soc/mediatek/mt8192: devapc: add basic dapc drivers

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 22 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 30 Oct 2020 03:42:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

3 Nov 3 Nov

1:59 p.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 23:

Pick: CB:47008 mb/google/asurada: Configure pins mode for SD

Update: CB:46687 mb/google/asurada: Implement enable_requlator and regulator_is_enabled

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 23 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 03 Nov 2020 12:59:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

11 Nov 11 Nov

6:44 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 25:

Update: CB:46401 soc/mediatek/mt8192: Reserve 44K SRAM for MCUPM working buffer CB:45398 soc/mediatek/mt8192: add pmif driver CB:45399 soc/mediatek/mt8192: add pmic MT6359P driver CB:45400 soc/mediatek/mt8192: add pmic MT6315 driver CB:46687 mb/google/asurada: Implement enable_regulator and regulator_is_enabled CB:46389 mediatek/mt8192: add spmfw loader CB:46392 soc/mediatek/mt8192: Load MCUPM firmware and boot up MCUPM Pick: CB:47293 mediatek/mt8192: memlayout: Add DRAM DMA region CB:46930 soc/mediatek/common: A common API for loading the blob file CB:47231 soc/mediatek/mt8192: Add 4266Mbps flag for dpm CB:46932 mt8192/dpm.c: use load_blob_file to load the blob files

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 25 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Nov 2020 05:44:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

6:50 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 25:

...

Patch Set 25:

Update: CB:46401 soc/mediatek/mt8192: Reserve 44K SRAM for MCUPM working buffer CB:45398 soc/mediatek/mt8192: add pmif driver CB:45399 soc/mediatek/mt8192: add pmic MT6359P driver CB:45400 soc/mediatek/mt8192: add pmic MT6315 driver CB:46687 mb/google/asurada: Implement enable_regulator and regulator_is_enabled CB:46389 mediatek/mt8192: add spmfw loader CB:46392 soc/mediatek/mt8192: Load MCUPM firmware and boot up MCUPM Pick: CB:47293 mediatek/mt8192: memlayout: Add DRAM DMA region CB:46930 soc/mediatek/common: A common API for loading the blob file CB:47231 soc/mediatek/mt8192: Add 4266Mbps flag for dpm CB:46932 mt8192/dpm.c: use load_blob_file to load the blob files

Update: CB:46395 soc/mediatek/mt8192: add rtc MT6359P driver

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 25 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 11 Nov 2020 05:50:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

13 Nov 13 Nov

10:39 a.m.

Hello Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#26).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 --- M 3rdparty/amd_blobs M 3rdparty/blobs M 3rdparty/intel-microcode M 3rdparty/qc_blobs M README.md 5 files changed, 5 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/26

Yidi Lin (Code Review)

10:46 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 26:

Update: CB:46401 soc/mediatek/mt8192: Reserve 44K SRAM for MCUPM working buffer CB:45398 soc/mediatek/mt8192: add pmif driver CB:46878 soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 26 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 13 Nov 2020 09:46:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

17 Nov 17 Nov

9:22 a.m.

Hello Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#27).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/27

Yidi Lin (Code Review)

9:28 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 27:

Update: CB:45398 soc/mediatek/mt8192: add pmif driver CB:46402 soc/mediatek/mt8192: devapc: add basic dapc drivers

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 27 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 17 Nov 2020 08:28:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

18 Nov 18 Nov

10:21 a.m.

Hello Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#28).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/28

Yidi Lin (Code Review)

10:29 a.m.

Hello Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#29).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/29

Yidi Lin (Code Review)

10:32 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 29:

Update: CB:46390 soc/mediatek: Move auxadc driver from MT8183 to common CB:46878 soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P drive Pick: CB:47696 soc/mediatek/mt8192: Add samsung sdparam config CB:47695 soc/mediatek/mt8192: Enable MT8192 auxadc driver

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 29 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 18 Nov 2020 09:32:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

20 Nov 20 Nov

7:05 a.m.

Hello Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#31).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/31

Yidi Lin (Code Review)

7:41 a.m.

Hello Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#32).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/32

Yidi Lin (Code Review)

9:24 a.m.

Hello Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#33).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/33

Yidi Lin (Code Review)

9:32 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 33:

Pick: CB:47392 WIP: soc/mediatek/mt8192: modify i2c and dma reset flow CB:46573 WIP: soc/mediatek/mt8192: add i2c driver support CB:46575 WIP: coreboot: Add anx7625 panel driver CB:47786 soc/mediatek/mt8192: Init SSPM

Update: CB:46390 soc/mediatek: Move auxadc driver from MT8183 to common CB:47695 soc/mediatek/mt8192: Enable MT8192 auxadc driver CB:46391 mb/google/asurada: Get RAM code from ADC 3 CB:46389 mediatek/mt8192: add spmfw loader

Exclude: CB:46410 HACK: soc/mediatek: Add function to raise the big CPU frequency CB:46411 HACK: soc/mediatek: Add function to raise the CCI frequency

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 33 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 20 Nov 2020 08:32:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

25 Nov 25 Nov

5:08 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 35:

Update: CB:46389 mediatek/mt8192: add spmfw loader Pick: CB:47986 HACK: mb/google/asurada: Keep sdram params in data section

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 35 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 25 Nov 2020 04:08:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

26 Nov 26 Nov

5:57 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 35:

Hi Hung-Te & Yu-Ping,

Please also review CB:47897 WIP: mediatek/mt8192/spm.c: Use mtlib_load_and_run API CB:47896 WIP: mediatek/common/mtlib.c: Refactor mtlib_load_and_run API CB:47895 WIP: mediatek/common/mtlib.c: refactor load_blob_file API

for load_blob_file API refactoring.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 35 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 26 Nov 2020 04:57:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Xi Chen (Code Review)

9:25 a.m.

Xi Chen has uploaded a new patch set (#36) to the change originally created by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/36

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 36 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

27 Nov 27 Nov

3:58 a.m.

Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#37).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/37

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 37 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

10:35 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 39:

Update: CB:46389 mediatek/mt8192: add spmfw loader CB:47800 soc/mediatek/mt8192: add i2c driver support - replace CB:47392 and CB:46573 CB:46575 WIP: coreboot: Add anx7625 panel driver

Pick: CB:47895 WIP: mediatek/common/mtlib.c: refactor load_blob_file API CB:47896 WIP: mediatek/common/mtlib.c: Refactor mtlib_load_and_run API CB:47897 WIP: mediatek/mt8192/spm.c: Use mtlib_load_and_run API CB:48110 soc/mediatek/mt8192: return correct voltage of VM18 CB:48073 soc/mediatek/mt8192: add dramc power control

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 39 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Comment-Date: Fri, 27 Nov 2020 09:35:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

1 Dec 1 Dec

9:16 a.m.

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 40:

Yidi, please include the display stack in asurada ToT. Thanks.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 40 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Comment-Date: Tue, 01 Dec 2020 08:16:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

9:20 a.m.

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 40:

...

Patch Set 40:

Yidi, please include the display stack in asurada ToT. Thanks.

Also, since CB:47903 has been merged, please rebase this onto master.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 40 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Comment-Date: Tue, 01 Dec 2020 08:20:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

2 Dec 2 Dec

10:28 a.m.

Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#41).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/41

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 41 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

10:33 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 41:

...

Patch Set 40:

...
Patch Set 40:

Yidi, please include the display stack in asurada ToT. Thanks.

Also, since CB:47903 has been merged, please rebase this onto master.

done

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 41 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Comment-Date: Wed, 02 Dec 2020 09:33:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

10:49 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 41:

Pick: - Display stack CB:46578 mb/google/asurada: Initialize display CB46576 mb/google/asurada: Enable DRIVER_ANALOGIX_ANX7625 CB:46577 soc/mediatek/mt8192: Add ddp driver CB:46574 soc/mediatek/mt8192: Add dsi driver - Support discrete DDR CB:48198 src/mediatek/mt8192: Add discrete DDR Support

Add: CB:48232 soc/mediatek/mt8183: Add DRAM_DMA section CB:48233 soc/mediatek/mt8183/sspm.c: Use mtlib_load_and_run API

Update: CB:46930 soc/mediatek/common: Add common API for loading firmwares CB:46389 soc/mediatek/mt8192: add spmfw loader CB:46392 soc/mediatek/mt8192: Load MCUPM firmware and boot up MCUPM CB:46393 soc/mediatek/mt8192: Add dpm loader CB:47786 soc/mediatek/mt8192: Init SSPM CB:47800 soc/mediatek/mt8192: add i2c driver support

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 41 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Comment-Date: Wed, 02 Dec 2020 09:49:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

10:56 a.m.

Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#42).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/42

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 42 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

10:58 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 42:

Update: CB:46389 soc/mediatek/mt8192: add spmfw loader - update commit message

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 42 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Comment-Date: Wed, 02 Dec 2020 09:58:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

4 Dec 4 Dec

5:21 a.m.

Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#44).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/44

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 44 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

10 Dec 10 Dec

3:07 p.m.

Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#45).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/45

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 45 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

3:09 p.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 45:

rebase to display ToT and resolve conflicts.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 45 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Comment-Date: Thu, 10 Dec 2020 14:09:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

16 Dec 16 Dec

10:01 a.m.

Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#47).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/47

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 47 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

10:07 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 48:

Pick: CB:48261 src/mediatek/mt8192: pass regulator function pointer to dram blob

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 48 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Comment-Date: Wed, 16 Dec 2020 09:07:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

22 Dec 22 Dec

2:34 p.m.

Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#49).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/49

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 49 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

2:37 p.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 49:

Rebase to HEAD:6c0aba2059.

Update: CB:46395 soc/mediatek/mt8192: add rtc MT6359P driver CB:46402 soc/mediatek/mt8192: devapc: add basic devapc drivers

Drop: CB:46883 soc/mediatek/mt8192: add rtc MT6359P lpd_init

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 49 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Comment-Date: Tue, 22 Dec 2020 13:37:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

31 Dec 31 Dec

5:15 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 50:

Pick: CL:49005 soc/mediatek/mt8192: pmic: update initial setting CL:48954 soc/mediatek/mt8192: pmic: unlock key protection before initial setting CL:49006 soc/mediatek/mt8192: pmic: add efuse setting

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 50 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Comment-Date: Thu, 31 Dec 2020 04:15:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

14 Jan 14 Jan

8:16 a.m.

Attention is currently required from: Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 50:

(1 comment)

Patchset:

PS50: Yidi, please pick CB:49453 for b/177399759.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 50 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Attention: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Thu, 14 Jan 2021 07:16:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

10:48 a.m.

Attention is currently required from: Yidi Lin. Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#51).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/51

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 51 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Attention: Yidi Lin yidi.lin@mediatek.com Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

11:07 a.m.

Attention is currently required from: Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 51:

(2 comments)

Patchset:

PS50:

...

Yidi, please pick CB:49453 for b/177399759.

done

Patchset:

PS51: Pick: CB:49355 soc/mediatek/mt8192: pmic: add scp voltage initialization CB:49354 soc/mediatek/mt8192: pmic: enable pwrkey long-press shutdown setting CB:49453 mb/google/asurada: Enable RTC for event log

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 51 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Attention: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Thu, 14 Jan 2021 10:07:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: comment

Yidi Lin (Code Review)

19 Jan 19 Jan

3:38 a.m.

Attention is currently required from: Yidi Lin, Yu-Ping Wu. Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#52).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/52

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 52 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Attention: Yidi Lin yidi.lin@mediatek.com Gerrit-Attention: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

3:45 a.m.

Attention is currently required from: Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 52:

(1 comment)

Patchset:

PS52: Drop: CB:48261 TEST-ONLY: src/mediatek/mt8192: pass regulator function pointer to dram blob

Pick: CB:48841 src/mediatek/mt8192: enable per-bank refresh to improve performance CB:49448 mb/google/asurada: Add generic DRAM groups CB:49634 mb/google/asurada: Add byte mode sdparam config

Update: CB:48198 src/mediatek/mt8192: Add discrete DDR Support

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 52 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Attention: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Tue, 19 Jan 2021 02:45:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

25 Jan 25 Jan

2:45 a.m.

Attention is currently required from: Yidi Lin, Yu-Ping Wu. Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#53).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/53

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 53 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Attention: Yidi Lin yidi.lin@mediatek.com Gerrit-Attention: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

26 Jan 26 Jan

2:58 p.m.

Attention is currently required from: Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 54:

(1 comment)

Patchset:

PS54: Pick: CB:46411 soc/mediatek/mt8192: Add function to raise the CCI frequency CB:49934 soc/mediatek/mt8192: Add mt6315_romstage_init CB:49935 mb/google/asurada: Improve boot time by raising little CPU frequency

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 54 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Attention: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Tue, 26 Jan 2021 13:58:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

1 Feb 1 Feb

12:30 p.m.

Attention is currently required from: Yu-Ping Wu. Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#55).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 --- M README.md 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/55

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 55 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Attention: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

12:31 p.m.

Attention is currently required from: Yu-Ping Wu. Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#56).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/56

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 56 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Attention: Yu-Ping Wu yupingso@google.com Gerrit-MessageType: newpatchset

Martin Roth (Code Review)

5:43 p.m.

Attention is currently required from: Yidi Lin, Yu-Ping Wu. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 56:

(1 comment)

File 3rdparty/amd_blobs:

https://review.coreboot.org/c/coreboot/+/46413/comment/75bab5b9_96b51f7f PS56, Line 1: Subproject commit 6d49f8b451536677289328be63890178a4f44d4b From Jenkins:

From https://review.coreboot.org/blobs * branch b7dbe885b7aeb9b6656b192171d8fc3c738bac2c -> FETCH_HEAD fatal: remote error: want 6d49f8b451536677289328be63890178a4f44d4b not valid

Everything needs to be merged to the 3rdparty repos before Jenkins can pull them correctly. Unfortunately it can't get patches that are just pushed to gerrit.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 56 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Attention: Yidi Lin yidi.lin@mediatek.com Gerrit-Attention: Yu-Ping Wu yupingso@google.com Gerrit-Comment-Date: Mon, 01 Feb 2021 16:43:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

2 Feb 2 Feb

5:52 a.m.

Attention is currently required from: Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 57:

(1 comment)

File 3rdparty/amd_blobs:

https://review.coreboot.org/c/coreboot/+/46413/comment/1988f34a_f1778824 PS56, Line 1: Subproject commit 6d49f8b451536677289328be63890178a4f44d4b

...

From Jenkins: […]

That is fine, because this CL is just a snapshot of the long CL chain, and we don't care the status of 3rdparty repos here.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 57 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Attention: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Tue, 02 Feb 2021 04:52:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth martinroth@google.com Gerrit-MessageType: comment

Yidi Lin (Code Review)

2 Mar 2 Mar

4:17 a.m.

Attention is currently required from: Yidi Lin. Hello Xi Chen, Hung-Te Lin, build bot (Jenkins), Roger Lu, pan gao, Sj Huang, CK HU, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46413

to look at the new patch set (#58).

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

DO-NOT-SUBMIT: Asurada ToT - Coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/46413/58

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 58 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Attention: Yidi Lin yidi.lin@mediatek.com Gerrit-MessageType: newpatchset

Yidi Lin (Code Review)

4:19 a.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 58:

(1 comment)

Patchset:

PS58: Rebase to 4778590d15 to fix depthcharge build failure.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 58 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Comment-Date: Tue, 02 Mar 2021 03:19:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

8 Mar 8 Mar

1:29 p.m.

Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 58:

(1 comment)

Patchset:

PS58: hungte@, can we abandon all patches in this chain now ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 58 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Comment-Date: Mon, 08 Mar 2021 12:29:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

9 Mar 9 Mar

2:22 a.m.

Attention is currently required from: Yidi Lin. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 58:

(1 comment)

Patchset:

PS58:

...

hungte@, can we abandon all patches in this chain now ?

Yes please abandon all DRAM related patches in the chain.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 58 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Attention: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Tue, 09 Mar 2021 01:22:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin yidi.lin@mediatek.com Gerrit-MessageType: comment

Yu-Ping Wu (Code Review)

3:38 a.m.

Attention is currently required from: Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Patch Set 58:

(1 comment)

Patchset:

PS58: Yidi, since DRAM code has been added to vendorcode, please abandon the whole chain.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 58 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-Attention: Yidi Lin yidi.lin@mediatek.com Gerrit-Comment-Date: Tue, 09 Mar 2021 02:38:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Yidi Lin (Code Review)

10:20 a.m.

Yidi Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46413 )

Change subject: DO-NOT-SUBMIT: Asurada ToT - Coreboot ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/46413 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd6 Gerrit-Change-Number: 46413 Gerrit-PatchSet: 58 Gerrit-Owner: Yidi Lin yidi.lin@mediatek.com Gerrit-Reviewer: CK HU ck.hu@mediatek.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Roger Lu roger.lu@mediatek.com Gerrit-Reviewer: Sj Huang sj.huang@mediatek.com Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: pan gao gtk_pangao@mediatek.com Gerrit-CC: Joel Kitching kitching@google.com Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Yidi Lin yidi.lin@mediatek.corp-partner.google.com Gerrit-MessageType: abandon

1142

days inactive

1288

days old

coreboot-gerrit@coreboot.org

67 comments

6 participants

tags (0)

participants (6)

Hung-Te Lin (Code Review)
Martin Roth (Code Review)
pan gao (Code Review)
Xi Chen (Code Review)
Yidi Lin (Code Review)
Yu-Ping Wu (Code Review)