Change in coreboot[master]: soc/intel/common: Add bootblock common stage file

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18457 )

Change subject: soc/intel/common: Add bootblock common stage file
......................................................................


Patch Set 38:

(2 comments)

https://review.coreboot.org/c/coreboot/+/18457/37/src/soc/intel/common/basecode/bootblock/bootblock.c 
File src/soc/intel/common/basecode/bootblock/bootblock.c:

https://review.coreboot.org/c/coreboot/+/18457/37/src/soc/intel/common/basecode/bootblock/bootblock.c@39 
PS37, Line 39: bootblock_soc_early_init(void)
> I think this is just to allow arbitrary function names. […]
The platform you mention doesn't support this kind of runtime detection. You have to specify the exact generation, otherwise it won't boot. For example:
* It doesn't include all microcodes 
* It has 3 different FSP for 4 different socs


https://review.coreboot.org/c/coreboot/+/18457/37/src/soc/intel/common/basecode/bootblock/bootblock.c@102 
PS37, Line 102: (CONFIG(PAGING_IN_CACHE_AS_RAM))
> I think APL/GLK differ too much from the big core platforms to have common code everywhere. […]
you consider 3 lines of code as too different?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/18457
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If84c08d33f6f8fd3cd9722ee893653f1d1ae90c1
Gerrit-Change-Number: 18457
Gerrit-PatchSet: 38
Gerrit-Owner: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Aamir Bohra <[e-mail]>
Gerrit-Reviewer: Aaron Durbin <[e-mail]>
Gerrit-Reviewer: Bernardo Perez Priego <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Maulik V Vaghela <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Rizwan Qureshi <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Usha P <[e-mail]>
Gerrit-Reviewer: V Sowmya <[e-mail]>
Gerrit-Reviewer: Varun Joshi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Angel Pons <[e-mail]>
Gerrit-CC: Arthur Heymans <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Mon, 03 Feb 2020 13:11:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <[e-mail]>
Comment-In-Reply-To: Angel Pons <[e-mail]>
Gerrit-MessageType: comment