Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7350
-gerrit
commit e0b14b1764e14dfff9be60dbd7b434a09da95721 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Fri Nov 7 12:43:49 2014 +1100
drivers/ioapic: DEVICE_NOOP some stub function callbacks
Just when you thought you found them all.. Reduces loc and makes NOP's explicit.
Change-Id: I416e0468b7f2f462c940daae695d67fb409aa4c6 Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/drivers/generic/ioapic/ioapic.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/src/drivers/generic/ioapic/ioapic.c b/src/drivers/generic/ioapic/ioapic.c index 9c4bc7d..463474a 100644 --- a/src/drivers/generic/ioapic/ioapic.c +++ b/src/drivers/generic/ioapic/ioapic.c @@ -20,6 +20,7 @@ static void ioapic_init(struct device *dev) u32 i, ioapic_interrupts; u32 ioapic_base; u8 ioapic_id; + if (!dev->enabled || !config) return;
@@ -86,14 +87,6 @@ static void ioapic_init(struct device *dev) } }
-static void ioapic_enable_resources(struct device *dev) -{ -} - -static void ioapic_nop(struct device *dummy) -{ -} - static void ioapic_read_resources(struct device *dev) { struct drivers_generic_ioapic_config *config = (struct drivers_generic_ioapic_config *)dev->chip_info; @@ -106,10 +99,10 @@ static void ioapic_read_resources(struct device *dev) }
static struct device_operations ioapic_operations = { - .read_resources = ioapic_read_resources, - .set_resources = ioapic_nop, - .enable_resources = ioapic_enable_resources, - .init = ioapic_init, + .read_resources = ioapic_read_resources, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, + .init = ioapic_init, };
static void enable_dev(struct device *dev)