Attention is currently required from: Martin Roth.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57346 )
Change subject: mb/intel/leafhill,minnow3: remove ADD_FSP_BINARIES config override
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Felix, that sounds like a good plan. Let's make it overridable at the FSP level.
there are also some other things i found in the fsp driver's Kconfig that could be improved, but not sure when/if i'll be looking into those, since those likely won't be a priority for me. but at least some of the problems are now more or less addressed, so i'd still count this as a win :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23439f3134eef9460625addbff7efd64c5f65ae5
Gerrit-Change-Number: 57346
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Sun, 05 Sep 2021 17:52:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment