Attention is currently required from: Henry Sun, Frank Chu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52565 )
Change subject: mb/google/dedede/var/galith: Support Wifi SAR for DVT phase
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/variants/galtic/variant.c:
https://review.coreboot.org/c/coreboot/+/52565/comment/6a0f9bbe_f7bf4cd2
PS1, Line 8: if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_DISABLED)))
: return "wifi_sar-galtic.hex";
I am confused now. Do we not want to control the transmit power for convertibles especially when operating in tablet mode.
Looking at the Default WIFI Sar file, it is empty.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9bb76c207ef033f81ecdd57849535b8ac8d13ae
Gerrit-Change-Number: 52565
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Mon, 26 Apr 2021 15:34:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment