[S] Change in coreboot[main]: util/smmstoretool: add uint64 data type
Attention is currently required from: Arthur Heymans, Martin L Roth, Michał Żygowski, Sergii Dmytruk. Krystian Hebel has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/82611?usp=email ) Change subject: util/smmstoretool: add uint64 data type ...................................................................... Patch Set 1: Code-Review+1 (3 comments) File util/smmstoretool/data.c: https://review.coreboot.org/c/coreboot/+/82611/comment/fcefefa1_1af91884?usp... : PS1, Line 168: data = xmalloc(*data_size); Nit: this isn't freed until program terminates. It shouldn't make a difference while this tool allows to operate on one variable at a time, but if it ever evolves to support multiple variables in one call it may become an issue. File util/smmstoretool/main.c: https://review.coreboot.org/c/coreboot/+/82611/comment/a2b5273e_5761407b?usp... : PS1, Line 128: 18446744073709551615 I have mixed feelings about such large number. I had to check if this value is correct because I'm 99% sure this is the first time I've seen it in decimal. While it makes sense for smaller sizes (it is what user would write), this is hardly readable, I think `2^64-1` would be better. https://review.coreboot.org/c/coreboot/+/82611/comment/1437b433_5458e957?usp... : PS1, Line 131: fprintf(f, " * raw (output only; raw bytes on output)\n"); Any plans for writing raw values, e.g. from provided file? -- To view, visit https://review.coreboot.org/c/coreboot/+/82611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4b46b41cdc5f69d4ca189659bef1e44f64c0d554 Gerrit-Change-Number: 82611 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Krystian Hebel <krystian.hebel@3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com> Gerrit-Reviewer: Michał Żygowski <miczyg94@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Martin L Roth <gaumless@gmail.com> Gerrit-Attention: Michał Żygowski <miczyg94@gmail.com> Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk@3mdeb.com> Gerrit-Comment-Date: Thu, 13 Jun 2024 09:44:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
participants (1)
-
Krystian Hebel (Code Review)