Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29962 )
Change subject: qcs405: clock: Adding the clock support for qcs405
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/29962/3/src/soc/qualcomm/qcs405/clock.c
File src/soc/qualcomm/qcs405/clock.c:
https://review.coreboot.org/#/c/29962/3/src/soc/qualcomm/qcs405/clock.c@65
PS3, Line 65: spi_cfg
which SPI buses are initialized here? We'll need SPI bus 4 rather early, so it should be covered here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29962
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I991bdde5f69e1c0f6ec5d6961275a1c077bc5bae
Gerrit-Change-Number: 29962
Gerrit-PatchSet: 3
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-Comment-Date: Fri, 11 Jan 2019 19:48:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment