Attention is currently required from: Nicholas Sudsgaard.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84606?usp=email )
Change subject: drivers/tpm: Use fieldlist for dynamic field creation ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84606/comment/f6d86ec9_43699f7f?usp... : PS3, Line 7: drivers/tpm: Use fieldlist for dynamic field creation : : Define TPPF field dynamically in the PPOP OpRegion, this : ensures that the offset stored in Local0 is used correctly. : : This fixes: : CreateByteField (PPOP, Local0, TPPF) : Error 6058 - Invalid type ^ ([Region] found, CreateByteField operator requires [Integer|String|Buffer]) :
I'm not really familiar with this part of the codebase, so I might not be understanding something, b […]
Sorry - I seem to have failed at pusing the right code...
File src/drivers/tpm/ppi.c:
https://review.coreboot.org/c/coreboot/+/84606/comment/d4ff3c4f_ebf3944b?usp... : PS2, Line 650: "
Remove this. […]
Done
File src/drivers/tpm/ppi.c:
https://review.coreboot.org/c/coreboot/+/84606/comment/999b64c7_95118b3c?usp... : PS3, Line 644: TPPF = CreateField("PPOP", Local0)
This seems wrong? […]
Done