Change in coreboot[master]: force --divide for iPXE default build

[Daniel Maslowski (Code Review)]

Daniel Maslowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35820 )


Change subject: force --divide for iPXE default build
......................................................................

force --divide for iPXE default build

Change-Id: Iafb314b6d0b978c1ca0f20128dda86b7153d9633
Signed-off-by: Daniel Maslowski <[e-mail]>
---
M payloads/external/iPXE/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/35820/1

diff --git a/payloads/external/iPXE/Makefile b/payloads/external/iPXE/Makefile
index 0c071fa..7005016 100644
--- a/payloads/external/iPXE/Makefile
+++ b/payloads/external/iPXE/Makefile
@@ -72,7 +72,7 @@
 	$(MAKE) -C $(project_dir)/src bin/$(PXE_ROM_PCI_ID).rom EMBED=$(CONFIG_SCRIPT)
 else
 	echo "    MAKE       $(project_name) $(TAG-y)"
-	$(MAKE) -C $(project_dir)/src bin/$(PXE_ROM_PCI_ID).rom
+	$(MAKE) -C $(project_dir)/src bin/$(PXE_ROM_PCI_ID).rom WORKAROUND_ASFLAGS="--divide"
 endif
 	cp $(project_dir)/src/bin/$(PXE_ROM_PCI_ID).rom $(project_dir)/ipxe.rom
 ifeq ($(CONSOLE_SERIAL),yy)

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/35820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafb314b6d0b978c1ca0f20128dda86b7153d9633
Gerrit-Change-Number: 35820
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Maslowski <[e-mail]>
Gerrit-MessageType: newchange

[Angel Pons (Code Review)]

Attention is currently required from: Daniel Maslowski.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35820 )

Change subject: force --divide for iPXE default build
......................................................................


Patch Set 1:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/35820/comment/9522f490_a18c5adc 
PS1, Line 8: 
Reason?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/35820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafb314b6d0b978c1ca0f20128dda86b7153d9633
Gerrit-Change-Number: 35820
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Maslowski <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Angel Pons <[e-mail]>
Gerrit-Attention: Daniel Maslowski <[e-mail]>
Gerrit-Comment-Date: Thu, 21 Jan 2021 20:48:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Daniel Maslowski (Code Review)]

Attention is currently required from: Angel Pons.
Daniel Maslowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35820 )

Change subject: force --divide for iPXE default build
......................................................................


Patch Set 1:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/35820/comment/76016e2a_95f374f6 
PS1, Line 8:
> Reason?
> Oh that's been a while. There were issues compiling it.

See also https://lists.ipxe.org/pipermail/ipxe-devel/2017-February/005462.html

It can be though that it works for most people without --divide.
I'd have to check again. =)



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/35820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafb314b6d0b978c1ca0f20128dda86b7153d9633
Gerrit-Change-Number: 35820
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Maslowski <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Angel Pons <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Comment-Date: Thu, 21 Jan 2021 23:25:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <[e-mail]>
Gerrit-MessageType: comment

[Idwer Vollering (Code Review)]

Attention is currently required from: Daniel Maslowski, Angel Pons.
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35820 )

Change subject: force --divide for iPXE default build
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
Did you observe that this fix solves a problem with a particular binutils version? (the coreboot toolchain ships binutils-2.35.1)



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/35820
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafb314b6d0b978c1ca0f20128dda86b7153d9633
Gerrit-Change-Number: 35820
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Maslowski <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Angel Pons <[e-mail]>
Gerrit-CC: Idwer Vollering <[e-mail]>
Gerrit-Attention: Daniel Maslowski <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Comment-Date: Fri, 22 Jan 2021 10:30:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[XS] Change in coreboot[master]: force --divide for iPXE default build

[Stefan Reinauer (Code Review)]

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35820?usp=email )

Change subject: force --divide for iPXE default build
......................................................................


Abandoned
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/35820?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafb314b6d0b978c1ca0f20128dda86b7153d9633
Gerrit-Change-Number: 35820
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Maslowski <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Angel Pons <[e-mail]>
Gerrit-CC: Idwer Vollering <[e-mail]>
Gerrit-MessageType: abandon