[M] Change in coreboot[master]: cpu/x86/smm: Enable setting SMM console log level from mainboard

[Paul Menzel (Code Review)]

Attention is currently required from: Marc Jones, Martin L Roth, Patrick Rudolph, Jonathan Zhang, Johnny Lin, Rocky Phagura, Jingle Hsu, Angel Pons, Arthur Heymans, Morgan Jang, Kyösti Mälkki.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49460 )

Change subject: cpu/x86/smm: Enable setting SMM console log level from mainboard
......................................................................

Patch Set 28:

(4 comments)

File src/cpu/x86/Kconfig:

https://review.coreboot.org/c/coreboot/+/49460/comment/8f81e045_8668b965 
PS28, Line 217: This enables setting SMM console log level from mainboard, it can let
              : 	  SMM have different log level than other stages for more flexibility.
“from mainboard” is ambiguous for me. Maybe keep using “at runtime”.

This enables setting the SMM console log level at runtime for more flexibility to use different log levels for each stage.

https://review.coreboot.org/c/coreboot/+/49460/comment/673d224d_37a2b6ec 
PS28, Line 219: certain data that requires searching
I do not know, what you mean here. Can you please rephrase or give an example?

File src/cpu/x86/smm/smm_module_handler.c:

https://review.coreboot.org/c/coreboot/+/49460/comment/2b7fa4f3_8ff0a85a 
PS28, Line 58: 	return smm_runtime.smm_log_level;
Can’t you do the check in C, and return 0 if `!IS_ENABLED(RUNTIME_CONFIGURABLE_SMM_LOGLEVEL)`?

File src/include/cpu/x86/smm.h:

https://review.coreboot.org/c/coreboot/+/49460/comment/a3c6b109_9d0edcb2 
PS28, Line 70: 	u8 smm_log_level;
In `src/console/init.c` `get_log_level()` returns int. Can we keep the `int`?