[S] Change in coreboot[master]: mb/starlabs/*: Add CMOS entries for the mirror flag
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73682 ) ( 9 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/starlabs/*: Add CMOS entries for the mirror flag ...................................................................... mb/starlabs/*: Add CMOS entries for the mirror flag Add the required CMOS entries for the mirror flag, so that it can be enabled from a defconfig. Signed-off-by: Sean Rhodes <sean@starlabs.systems> Change-Id: I174ac896df050480ee90c8141c5536b628c98432 Reviewed-on: https://review.coreboot.org/c/coreboot/+/73682 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> --- M src/mainboard/starlabs/lite/cmos.default M src/mainboard/starlabs/lite/cmos.layout M src/mainboard/starlabs/lite/variants/glkr/cmos.default M src/mainboard/starlabs/lite/variants/glkr/cmos.layout M src/mainboard/starlabs/starbook/cmos.default M src/mainboard/starlabs/starbook/cmos.layout M src/mainboard/starlabs/starbook/variants/tgl/cmos.default M src/mainboard/starlabs/starbook/variants/tgl/cmos.layout 8 files changed, 28 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/mainboard/starlabs/lite/cmos.default b/src/mainboard/starlabs/lite/cmos.default index 2455e2b..c59bbe5 100644 --- a/src/mainboard/starlabs/lite/cmos.default +++ b/src/mainboard/starlabs/lite/cmos.default @@ -12,6 +12,7 @@ # EC kbl_timeout=30 seconds fn_ctrl_swap=Disable +mirror_flag=Disable # southbridge power_on_after_fail=Disable # Functions diff --git a/src/mainboard/starlabs/lite/cmos.layout b/src/mainboard/starlabs/lite/cmos.layout index e6b3be2..71dd390 100644 --- a/src/mainboard/starlabs/lite/cmos.layout +++ b/src/mainboard/starlabs/lite/cmos.layout @@ -28,6 +28,8 @@ # coreboot config options: EC 600 3 e 4 kbl_timeout 608 1 e 1 fn_ctrl_swap +616 1 e 1 mirror_flag +624 4 h 0 mirror_flag_counter # coreboot config options: southbridge 800 2 e 6 power_on_after_fail diff --git a/src/mainboard/starlabs/lite/variants/glkr/cmos.default b/src/mainboard/starlabs/lite/variants/glkr/cmos.default index dedd7f7..3dbe92d 100644 --- a/src/mainboard/starlabs/lite/variants/glkr/cmos.default +++ b/src/mainboard/starlabs/lite/variants/glkr/cmos.default @@ -13,6 +13,7 @@ kbl_timeout=30 seconds fn_ctrl_swap=Disable fast_charge=Normal +mirror_flag=Disable # southbridge power_on_after_fail=Disable # Functions diff --git a/src/mainboard/starlabs/lite/variants/glkr/cmos.layout b/src/mainboard/starlabs/lite/variants/glkr/cmos.layout index 3dfc8de..d53116c 100644 --- a/src/mainboard/starlabs/lite/variants/glkr/cmos.layout +++ b/src/mainboard/starlabs/lite/variants/glkr/cmos.layout @@ -29,6 +29,8 @@ 600 3 e 4 kbl_timeout 608 1 e 1 fn_ctrl_swap 616 1 e 11 fast_charge +624 1 e 1 mirror_flag +632 4 h 0 mirror_flag_counter # coreboot config options: southbridge 800 2 e 6 power_on_after_fail diff --git a/src/mainboard/starlabs/starbook/cmos.default b/src/mainboard/starlabs/starbook/cmos.default index 151686c..18abc93 100644 --- a/src/mainboard/starlabs/starbook/cmos.default +++ b/src/mainboard/starlabs/starbook/cmos.default @@ -16,6 +16,7 @@ # EC kbl_timeout=30 seconds fn_ctrl_swap=Disable +mirror_flag=Disable # southbridge power_on_after_fail=Disable # Functions diff --git a/src/mainboard/starlabs/starbook/cmos.layout b/src/mainboard/starlabs/starbook/cmos.layout index 9fc0b7d..fa912b5 100644 --- a/src/mainboard/starlabs/starbook/cmos.layout +++ b/src/mainboard/starlabs/starbook/cmos.layout @@ -35,6 +35,8 @@ 608 1 e 1 fn_ctrl_swap 616 2 e 8 max_charge 624 2 e 9 fan_mode +632 1 e 1 mirror_flag +640 4 h 0 mirror_flag_counter # coreboot config options: southbridge 800 2 e 6 power_on_after_fail diff --git a/src/mainboard/starlabs/starbook/variants/tgl/cmos.default b/src/mainboard/starlabs/starbook/variants/tgl/cmos.default index cfc9a61..cca64fe 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/cmos.default +++ b/src/mainboard/starlabs/starbook/variants/tgl/cmos.default @@ -16,6 +16,7 @@ # EC kbl_timeout=30 seconds fn_ctrl_swap=Disable +mirror_flag=Disable # southbridge power_on_after_fail=Disable # Functions diff --git a/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout b/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout index c4a49c5d..1700d0d 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout +++ b/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout @@ -35,6 +35,8 @@ 608 1 e 1 fn_ctrl_swap 616 2 e 8 max_charge 624 2 e 9 fan_mode +632 1 e 1 mirror_flag +640 4 h 0 mirror_flag_counter # coreboot config options: southbridge 800 2 e 6 power_on_after_fail -- To view, visit https://review.coreboot.org/c/coreboot/+/73682 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I174ac896df050480ee90c8141c5536b628c98432 Gerrit-Change-Number: 73682 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <sean@starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
participants (1)
-
Felix Held (Code Review)