Attention is currently required from: Julius Werner, Jérémy Compostella, Nicholas Chin.
Subrata Banik has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85905?usp=email )
Change subject: drivers/option: Add CBFS file based option backend ......................................................................
Patch Set 12:
(2 comments)
Patchset:
PS4:
I had similar thoughts initially which is why I had asked about it. Leaving the code as is for now until this gets sorted out for your use case. I see that CB:86001 currently uses `HAVE_CBFS_FILE_OPTION_BACKEND`.
We can use `default USE_CBFS_FILE_OPTION_BACKEND if CONFIG_CHROMEOS` but there are two downsides.
First, we are forcing all previous and future generations of chromeos devices to bind with `USE_CBFS_FILE_OPTION_BACKEND`. Rather, the flexibility should be given to the desired platform to decide if they wish to use it.
Second, what about non-CrOS devices? They might also wish to use the `USE_CBFS_FILE_OPTION_BACKEND` feature. The current model of relying on `HAVE_` would allow any SoC/Mainboard to select this feature as per their need. Although there is a cost for extra `HAVE_` kconfig, it looks like the same works for other choice options as well.
File src/include/option.h:
https://review.coreboot.org/c/coreboot/+/85905/comment/cbb42d56_ac3d1624?usp... : PS9, Line 16: return fallback;
Shouldn't an error be printed ? A call to get_uint_option() in SMM should be considered an issue a […]
Acknowledged
-
Subrata Banik (Code Review)