Attention is currently required from: Balaji Manigandan, Deepti Deshatty, Kapil Porwal, Krishna P Bhat D, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79209?usp=email )
Change subject: mb/intel/mtlrvp: add 512KB SI_EC FMAP region
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79209/comment/c3416b59_d8dd9578 :
PS7, Line 19: TEST=build "emerge-rex coreboot chromeos-bootimage" is successful
“and the changes are verified” sounds like you even runtime tested this. Maybe show the log line, stating the EC1723 loaded the firmware.
(Feel free to ignore the comment, but keep it mind for next time.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79209?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I788dbeaad05e5d6904fb2c7c681a0bf653dc7d84
Gerrit-Change-Number: 79209
Gerrit-PatchSet: 7
Gerrit-Owner: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Deepti Deshatty
deepti.deshatty@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Comment-Date: Tue, 05 Dec 2023 14:20:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment