Attention is currently required from: Jamie Chen, Tarun Tuli, Ian Feng.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71706 )
Change subject: mb/google/brya/var/omnigul: Update GPIO settings ......................................................................
Patch Set 9: Code-Review+1
(12 comments)
File src/mainboard/google/brya/variants/omnigul/gpio.c:
https://review.coreboot.org/c/coreboot/+/71706/comment/3e1dbf5c_84d05b95 PS9, Line 92: PAD_CFG_GPI_APIC_LOCK(GPP_D5, NONE, LEVEL, NONE, LOCK_CONFIG), Does it use for interrupt? If no, it might be PAD_CFG_GPI_LOCK.
https://review.coreboot.org/c/coreboot/+/71706/comment/a53e1d16_6202d3c1 PS9, Line 96: PAD_CFG_GPI_APIC Does it use for interrupt? If no, it might be PAD_CFG_GPI.
https://review.coreboot.org/c/coreboot/+/71706/comment/a654caa4_d027cc0f PS9, Line 104: PAD_CFG_GPI_APIC Same as GPP_D8.
https://review.coreboot.org/c/coreboot/+/71706/comment/108aa692_4d323620 PS9, Line 108: PAD_CFG_GPI_APIC Same as GPP_D8.
https://review.coreboot.org/c/coreboot/+/71706/comment/2b2634d2_39a00721 PS9, Line 110: PAD_CFG_GPI_APIC Same as GPP_D8.
https://review.coreboot.org/c/coreboot/+/71706/comment/011f07c2_bfca600b PS9, Line 112: PAD_CFG_GPI_APIC Same as GPP_D8.
https://review.coreboot.org/c/coreboot/+/71706/comment/74074aca_6b5b8240 PS9, Line 122: PAD_CFG_GPI_APIC Same as GPP_D8.
https://review.coreboot.org/c/coreboot/+/71706/comment/93283b1d_6ddcd7a9 PS9, Line 128: PAD_CFG_GPI_APIC Same as GPP_D8.
https://review.coreboot.org/c/coreboot/+/71706/comment/e0bf2828_c60e2c30 PS9, Line 132: PAD_CFG_GPI_APIC_LOCK(GPP_E10, NONE, LEVEL, NONE, LOCK_CONFIG), Same as GPP_D5.
https://review.coreboot.org/c/coreboot/+/71706/comment/b75c59c7_a96c294c PS9, Line 141: PAD_CFG_GPI_APIC_LOCK(GPP_E17, NONE, LEVEL, NONE, LOCK_CONFIG), Same as GPP_D5.
https://review.coreboot.org/c/coreboot/+/71706/comment/6f6e4b32_430bddf5 PS9, Line 145: PAD_CFG_GPI_APIC Same as GPP_D8.
https://review.coreboot.org/c/coreboot/+/71706/comment/1e98c83a_d75a4eb9 PS9, Line 180: PAD_CFG_GPI_APIC_LOCK Same as GPP_D5.
-
Dtrain Hsu (Code Review)