Attention is currently required from: Hung-Te Lin, Rex-BC Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56764 )
Change subject: soc/mediatek/mt8195: Add devapc basic drivers ......................................................................
Patch Set 3:
(8 comments)
File src/soc/mediatek/mt8195/include/soc/devapc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577): https://review.coreboot.org/c/coreboot/+/56764/comment/17535748_82f6eb31 PS3, Line 72: #define DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577): https://review.coreboot.org/c/coreboot/+/56764/comment/f5da19d7_848b5c47 PS3, Line 77: #define DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577): https://review.coreboot.org/c/coreboot/+/56764/comment/a5b6f821_cdb091be PS3, Line 85: #define DAPC_PERM_ATTR_16(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577): https://review.coreboot.org/c/coreboot/+/56764/comment/80e79198_9d98a019 PS3, Line 99: #define FORBIDDEN3 FORBIDDEN, FORBIDDEN, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577): https://review.coreboot.org/c/coreboot/+/56764/comment/87c566e8_9179ff24 PS3, Line 100: #define FORBIDDEN7 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577): https://review.coreboot.org/c/coreboot/+/56764/comment/fdb50af5_152b351a PS3, Line 102: #define FORBIDDEN12 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577): https://review.coreboot.org/c/coreboot/+/56764/comment/a39d0f6d_3f5a19b4 PS3, Line 105: #define FORBIDDEN13 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125577): https://review.coreboot.org/c/coreboot/+/56764/comment/ef72a70c_92e0f013 PS3, Line 108: #define FORBIDDEN15 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \ Macros with complex values should be enclosed in parentheses
-
build bot (Jenkins) (Code Review)