Attention is currently required from: Henry Sun, Paul Menzel, Paul Fagerburg, Karthik Ramasubramanian.
Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57977 )
Change subject: mb/google/dedede/var/boten: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 3:
(3 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/57977/comment/4b38ce94_2bfa58e7
PS1, Line 9: ALC5682
ALC5682I?
Done
File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/57977/comment/cd71db1f_4fbd6a60
PS1, Line 2: 41 43
Please confirm that EC is not using these SSFC bits for other purposes.
Yes, we refer chromium:3021932 and deal with EC to use SSFC bit 9-11 for audio codec scope.
https://review.coreboot.org/c/coreboot/+/57977/comment/99470136_4ea4affb
PS1, Line 5:
Nit: Using tab here whereas using space in the previous lines. Recommend to use either tab or space.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57977
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba91b51cbbe7adc502372c9a026867de61d8035d
Gerrit-Change-Number: 57977
Gerrit-PatchSet: 3
Gerrit-Owner: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 28 Sep 2021 02:57:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment