Change in coreboot[master]: sb/intel/common/acpi: Add more Windows versions

[Peter Lemenkov (Code Review)]

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37943 )

Change subject: sb/intel/common/acpi: Add more Windows versions
......................................................................

sb/intel/common/acpi: Add more Windows versions

Change-Id: I5ee724f0b03edbfff7dd5b2ae642020cbcbab6d2
Signed-off-by: Peter Lemenkov 
---
M src/southbridge/intel/common/acpi/platform.asl
1 file changed, 24 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37943/1

diff --git a/src/southbridge/intel/common/acpi/platform.asl b/src/southbridge/intel/common/acpi/platform.asl
index 03cb625..9cd41eb 100644
--- a/src/southbridge/intel/common/acpi/platform.asl
+++ b/src/southbridge/intel/common/acpi/platform.asl
@@ -79,6 +79,14 @@
    		Store (2001, OSYS)
    	}

+		If (_OSI("Windows 2001.1")) {
+			Store (2001, OSYS)
+		}
+
+		If (_OSI("Windows 2001.1 SP1")) {
+			Store (2001, OSYS)
+		}
+
    	If (_OSI("Windows 2001 SP2")) {
    		Store (2002, OSYS)
    	}
@@ -86,5 +94,21 @@
    	If (_OSI("Windows 2006")) {
    		Store (2006, OSYS)
    	}
+
+		If (_OSI("Windows 2006 SP1")) {
+			Store (2006, OSYS)
+		}
+
+		If (_OSI("Windows 2006.1")) {
+			Store (2006, OSYS)
+		}
+
+		If (_OSI("Windows 2009")) {
+			Store (2009, OSYS)
+		}
+
+		If (_OSI("Windows 2012")) {
+			Store (2012, OSYS)
+		}
    }
 }

[Peter Lemenkov (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37943

to look at the new patch set (#2).

Change subject: sb/intel/common/acpi: Add more Windows versions
......................................................................

sb/intel/common/acpi: Add more Windows versions

For the upi-to-date list of Windows versions see this link:

https://docs.microsoft.com/en-us/windows-hardware/drivers/acpi/winacpi-osi

Change-Id: I5ee724f0b03edbfff7dd5b2ae642020cbcbab6d2
Signed-off-by: Peter Lemenkov 
---
M src/southbridge/intel/common/acpi/platform.asl
1 file changed, 32 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37943/2

[Peter Lemenkov (Code Review)]

Hello Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37943

to look at the new patch set (#3).

Change subject: sb/intel/common/acpi: Add more Windows versions
......................................................................

sb/intel/common/acpi: Add more Windows versions

For the up-to-date list of Windows versions follow this link:

https://docs.microsoft.com/en-us/windows-hardware/drivers/acpi/winacpi-osi

Change-Id: I5ee724f0b03edbfff7dd5b2ae642020cbcbab6d2
Signed-off-by: Peter Lemenkov 
---
M src/southbridge/intel/common/acpi/platform.asl
1 file changed, 32 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/37943/3

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37943 )

Change subject: sb/intel/common/acpi: Add more Windows versions
......................................................................

Patch Set 3:

What kind of workarounds need this code?

[Peter Lemenkov (Code Review)]

Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37943 )

Change subject: sb/intel/common/acpi: Add more Windows versions
......................................................................

Patch Set 3:
> Patch Set 3:
>
> What kind of workarounds need this code?

Can't say. I've just updated a common code with one from boards which actually use it.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37943 )

Change subject: sb/intel/common/acpi: Add more Windows versions
......................................................................

Patch Set 3: Code-Review+1

[Alexander Couzens (Code Review)]

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37943 )

Change subject: sb/intel/common/acpi: Add more Windows versions
......................................................................

Patch Set 4:

Is there a reason why you leave some versions out?

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37943 )

Change subject: sb/intel/common/acpi: Add more Windows versions
......................................................................

Patch Set 4: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37943 )

Change subject: sb/intel/common/acpi: Add more Windows versions
......................................................................

sb/intel/common/acpi: Add more Windows versions

For the up-to-date list of Windows versions follow this link:

https://docs.microsoft.com/en-us/windows-hardware/drivers/acpi/winacpi-osi

Change-Id: I5ee724f0b03edbfff7dd5b2ae642020cbcbab6d2
Signed-off-by: Peter Lemenkov 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37943
Reviewed-by: Patrick Georgi 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M src/southbridge/intel/common/acpi/platform.asl
1 file changed, 32 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve

diff --git a/src/southbridge/intel/common/acpi/platform.asl b/src/southbridge/intel/common/acpi/platform.asl
index 03cb625..057d5c2 100644
--- a/src/southbridge/intel/common/acpi/platform.asl
+++ b/src/southbridge/intel/common/acpi/platform.asl
@@ -61,10 +61,16 @@
     *    OSYS value | Operating System
     *    -----------+------------------
     *       2000    | Windows 2000
-	 *       2001    | Windows XP(+SP1)
+	 *       2001    | Windows XP
+	 *       2001    | Windows XP SP1
+	 *       2001    | Windows Server 2003
+	 *       2001    | Windows Server 2003 SP1
     *       2002    | Windows XP SP2
     *       2006    | Windows Vista
-	 *       ????    | Windows 7
+	 *       2006    | Windows Vista SP1
+	 *       2006    | Windows Server 2008
+	 *       2009    | Windows 7
+	 *       2012    | Windows 8
     */

/* Let's assume we're running at least Windows 2000 */
@@ -79,6 +85,14 @@
    		Store (2001, OSYS)
    	}

+		If (_OSI("Windows 2001.1")) {
+			Store (2001, OSYS)
+		}
+
+		If (_OSI("Windows 2001.1 SP1")) {
+			Store (2001, OSYS)
+		}
+
    	If (_OSI("Windows 2001 SP2")) {
    		Store (2002, OSYS)
    	}
@@ -86,5 +100,21 @@
    	If (_OSI("Windows 2006")) {
    		Store (2006, OSYS)
    	}
+
+		If (_OSI("Windows 2006 SP1")) {
+			Store (2006, OSYS)
+		}
+
+		If (_OSI("Windows 2006.1")) {
+			Store (2006, OSYS)
+		}
+
+		If (_OSI("Windows 2009")) {
+			Store (2009, OSYS)
+		}
+
+		If (_OSI("Windows 2012")) {
+			Store (2012, OSYS)
+		}
    }
 }